Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2580363002: Upstream Chrome on iOS source code [1/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, msramek+watch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, markusheintz_, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [1/11]. Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking the downstream tree. BUG=653086 Committed: https://crrev.com/34e9bd4175ba0c3caf24f32559360a4a3a484144 Cr-Commit-Position: refs/heads/master@{#439455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19866 lines, -0 lines) Patch
A ios/chrome/app/README.md View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/app/app_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/app/app_delegate.mm View 1 chunk +121 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/app_navigation.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/app_state.h View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/app_state.mm View 1 chunk +499 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/app_state_testing.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/app_state_unittest.mm View 1 chunk +933 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/background_activity.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/background_activity.mm View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/background_activity_unittest.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/browser_launcher.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/fake_startup_information.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/fake_startup_information.mm View 1 chunk +65 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/metrics_mediator.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/metrics_mediator.mm View 1 chunk +394 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/metrics_mediator_testing.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/metrics_mediator_unittest.mm View 1 chunk +276 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/mock_tab_opener.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/mock_tab_opener.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/startup_information.h View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/tab_opening.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/tab_switching.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/url_opener.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/url_opener.mm View 1 chunk +97 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/url_opener_unittest.mm View 1 chunk +482 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/user_activity_handler.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/user_activity_handler.mm View 1 chunk +320 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/user_activity_handler_unittest.mm View 1 chunk +625 lines, -0 lines 0 comments Download
A ios/chrome/app/application_mode.h View 1 chunk +11 lines, -0 lines 0 comments Download
A ios/chrome/app/application_phase.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/app/application_state.h View 1 chunk +113 lines, -0 lines 0 comments Download
A ios/chrome/app/application_state.mm View 1 chunk +110 lines, -0 lines 0 comments Download
A ios/chrome/app/application_step.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_app_startup_parameters.h View 1 chunk +110 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_app_startup_parameters.mm View 1 chunk +339 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_app_startup_parameters_unittest.mm View 1 chunk +244 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_exe_main.mm View 1 chunk +69 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_overlay_window.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_overlay_window.mm View 1 chunk +96 lines, -0 lines 0 comments Download
A ios/chrome/app/chrome_overlay_window_testing.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/app/main.mm View 1 chunk +72 lines, -0 lines 0 comments Download
A ios/chrome/app/main_application_delegate.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/app/main_application_delegate.mm View 1 chunk +274 lines, -0 lines 0 comments Download
A ios/chrome/app/main_application_delegate_testing.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/app/main_application_delegate_unittest.mm View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/app/main_controller.h View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/app/main_controller.mm View 1 chunk +2757 lines, -0 lines 0 comments Download
A ios/chrome/app/main_controller_private.h View 1 chunk +80 lines, -0 lines 0 comments Download
A ios/chrome/app/main_controller_unittest.mm View 1 chunk +143 lines, -0 lines 0 comments Download
A ios/chrome/app/memory_monitor.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/app/memory_monitor.mm View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/app/multitasking_test_application_delegate.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/app/multitasking_test_application_delegate.mm View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_coordinator.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_coordinator.mm View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_egtest.mm View 1 chunk +160 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_view_controller.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_view_controller.mm View 1 chunk +305 lines, -0 lines 0 comments Download
A ios/chrome/app/safe_mode/safe_mode_view_controller_unittest.mm View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/actions_spotlight_manager.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/actions_spotlight_manager.mm View 1 chunk +205 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/base_spotlight_manager.h View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/base_spotlight_manager.mm View 1 chunk +272 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/bookmarks_spotlight_manager.h View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm View 1 chunk +348 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/spotlight_manager.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/spotlight_manager.mm View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/spotlight_manager_unittest.mm View 1 chunk +204 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/spotlight_util.h View 1 chunk +75 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/spotlight_util.mm View 1 chunk +216 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/topsites_spotlight_manager.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/spotlight/topsites_spotlight_manager.mm View 1 chunk +288 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/chrome_main_starter.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/chrome_main_starter.mm View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/client_registration.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/client_registration.mm View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/ios_chrome_main.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/ios_chrome_main.mm View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/ios_chrome_main_delegate.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/ios_chrome_main_delegate.mm View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/network_stack_setup.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/network_stack_setup.mm View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/provider_registration.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/provider_registration.mm View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/register_experimental_settings.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/register_experimental_settings.mm View 1 chunk +128 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/setup_debugging.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/setup_debugging.mm View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/app/startup_tasks.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/app/startup_tasks.mm View 1 chunk +107 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_background.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_background.mm View 1 chunk +131 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_basic.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_basic.mm View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_foreground.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/launch_to_foreground.mm View 1 chunk +130 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/tab_grid_coordinator+application_step.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/app/steps/tab_grid_coordinator+application_step.mm View 1 chunk +80 lines, -0 lines 0 comments Download
A ios/chrome/browser/README.md View 1 chunk +10 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_agent.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_agent.mm View 1 chunk +870 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_controller.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_controller.mm View 1 chunk +200 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_controller_js_unittest.mm View 1 chunk +1796 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_controller_unittest.mm View 1 chunk +587 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_egtest.mm View 1 chunk +161 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_structure_browsertest.mm View 1 chunk +156 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm View 1 chunk +451 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/js_autofill_manager_unittest.mm View 1 chunk +143 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/js_suggestion_manager_unittest.mm View 1 chunk +373 lines, -0 lines 0 comments Download
A ios/chrome/browser/browser_coordinator.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/browser_coordinator.mm View 1 chunk +113 lines, -0 lines 0 comments Download
A ios/chrome/browser/browser_coordinator+internal.h View 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/browser/browsing_data/browsing_data_removal_controller.h View 1 chunk +71 lines, -0 lines 0 comments Download
A ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm View 1 chunk +453 lines, -0 lines 0 comments Download
A ios/chrome/browser/browsing_data/browsing_data_removal_controller_unittest.mm View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/callback_counter.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/callback_counter.mm View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/callback_counter_unittest.mm View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/context_menu/context_menu_egtest.mm View 1 chunk +240 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_report/breakpad_helper_unittest.mm View 1 chunk +152 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_report/crash_report_helper.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_report/crash_report_helper.mm View 1 chunk +352 lines, -0 lines 0 comments Download
A ios/chrome/browser/crash_report/crash_restore_helper.h View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sdefresne
Please take a look.
4 years ago (2016-12-19 12:10:24 UTC) #4
rohitrao (ping after 24h)
lgtm! Let's get this party started!
4 years ago (2016-12-19 12:34:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580363002/1
4 years ago (2016-12-19 12:36:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 12:46:09 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 12:50:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34e9bd4175ba0c3caf24f32559360a4a3a484144
Cr-Commit-Position: refs/heads/master@{#439455}

Powered by Google App Engine
This is Rietveld 408576698