Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: ios/chrome/browser/autofill/form_structure_browsertest.mm

Issue 2580363002: Upstream Chrome on iOS source code [1/11]. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/autofill/form_structure_browsertest.mm
diff --git a/ios/chrome/browser/autofill/form_structure_browsertest.mm b/ios/chrome/browser/autofill/form_structure_browsertest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..6c05bd0429a490ff3a8a1dd501f4675cc871dcc9
--- /dev/null
+++ b/ios/chrome/browser/autofill/form_structure_browsertest.mm
@@ -0,0 +1,156 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "base/files/file_enumerator.h"
+#include "base/files/file_path.h"
+#include "base/mac/foundation_util.h"
+#include "base/memory/ptr_util.h"
+#include "base/path_service.h"
+#include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/browser/autofill_manager.h"
+#include "components/autofill/core/browser/data_driven_test.h"
+#include "components/autofill/ios/browser/autofill_driver_ios.h"
+#import "ios/chrome/browser/autofill/autofill_agent.h"
+#import "ios/chrome/browser/autofill/autofill_controller.h"
+#import "ios/chrome/browser/autofill/form_suggestion_controller.h"
+#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
+#include "ios/chrome/browser/chrome_paths.h"
+#include "ios/chrome/browser/infobars/infobar_manager_impl.h"
+#import "ios/chrome/browser/web/chrome_web_test.h"
+#import "ios/web/public/web_state/web_state.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace autofill {
+
+namespace {
+
+const base::FilePath::CharType kTestName[] = FILE_PATH_LITERAL("heuristics");
+
+const base::FilePath& GetTestDataDir() {
+ CR_DEFINE_STATIC_LOCAL(base::FilePath, dir, ());
+ if (dir.empty())
+ PathService::Get(ios::DIR_TEST_DATA, &dir);
+ return dir;
+}
+
+const std::vector<base::FilePath> GetTestFiles() {
+ base::FilePath dir;
+ CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &dir));
+ dir = dir.AppendASCII("ios/chrome/test/data/autofill")
+ .Append(kTestName)
+ .AppendASCII("input");
+ base::FileEnumerator input_files(dir, false, base::FileEnumerator::FILES);
+ std::vector<base::FilePath> files;
+ for (base::FilePath input_file = input_files.Next(); !input_file.empty();
+ input_file = input_files.Next()) {
+ files.push_back(input_file);
+ }
+ std::sort(files.begin(), files.end());
+
+ base::mac::ClearAmIBundledCache();
+ return files;
+}
+
+} // namespace
+
+// Test fixture for verifying Autofill heuristics. Each input is an HTML
+// file that contains one or more forms. The corresponding output file lists the
+// heuristically detected type for each field.
+// This is based on FormStructureBrowserTest from the Chromium Project.
+// TODO(crbug.com/245246): Unify the tests.
+class FormStructureBrowserTest
+ : public ChromeWebTest,
+ public DataDrivenTest,
+ public ::testing::WithParamInterface<base::FilePath> {
+ protected:
+ FormStructureBrowserTest();
+ ~FormStructureBrowserTest() override {}
+
+ void SetUp() override;
+ void TearDown() override;
+
+ // DataDrivenTest:
+ void GenerateResults(const std::string& input, std::string* output) override;
+
+ // Serializes the given |forms| into a string.
+ std::string FormStructuresToString(
+ const std::vector<std::unique_ptr<FormStructure>>& forms);
+
+ FormSuggestionController* suggestionController_;
+ AutofillController* autofillController_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FormStructureBrowserTest);
+};
+
+FormStructureBrowserTest::FormStructureBrowserTest()
+ : DataDrivenTest(GetTestDataDir()) {}
+
+void FormStructureBrowserTest::SetUp() {
+ ChromeWebTest::SetUp();
+
+ InfoBarManagerImpl::CreateForWebState(web_state());
+ AutofillAgent* autofillAgent =
+ [[AutofillAgent alloc] initWithBrowserState:chrome_browser_state_.get()
+ webState:web_state()];
+ suggestionController_ =
+ [[FormSuggestionController alloc] initWithWebState:web_state()
+ providers:@[ autofillAgent ]];
+ autofillController_ = [[AutofillController alloc]
+ initWithBrowserState:chrome_browser_state_.get()
+ webState:web_state()
+ autofillAgent:autofillAgent
+ passwordGenerationManager:nullptr
+ downloadEnabled:NO];
+}
+
+void FormStructureBrowserTest::TearDown() {
+ [autofillController_ detachFromWebState];
+
+ ChromeWebTest::TearDown();
+}
+
+void FormStructureBrowserTest::GenerateResults(const std::string& input,
+ std::string* output) {
+ LoadHtml(input);
+ AutofillManager* autofill_manager =
+ AutofillDriverIOS::FromWebState(web_state())->autofill_manager();
+ ASSERT_NE(nullptr, autofill_manager);
+ const std::vector<std::unique_ptr<FormStructure>>& forms =
+ autofill_manager->form_structures_;
+ *output = FormStructureBrowserTest::FormStructuresToString(forms);
+}
+
+std::string FormStructureBrowserTest::FormStructuresToString(
+ const std::vector<std::unique_ptr<FormStructure>>& forms) {
+ std::string forms_string;
+ for (const std::unique_ptr<FormStructure>& form : forms) {
+ for (const AutofillField* field : *form) {
+ forms_string += field->Type().ToString();
+ forms_string += " | " + base::UTF16ToUTF8(field->name);
+ forms_string += " | " + base::UTF16ToUTF8(field->label);
+ forms_string += " | " + base::UTF16ToUTF8(field->value);
+ forms_string += " | " + field->section();
+ forms_string += "\n";
+ }
+ }
+ return forms_string;
+}
+
+// Disabled because the tests don't pass yet: http://crbug.com/427614
+// Disabled because the tests crash flakily: http://crbug.com/464383
+TEST_P(FormStructureBrowserTest, DISABLED_DataDrivenHeuristics) {
+ RunOneDataDrivenTest(GetParam(), GetOutputDirectory(kTestName));
+}
+
+INSTANTIATE_TEST_CASE_P(AllForms,
+ FormStructureBrowserTest,
+ testing::ValuesIn(GetTestFiles()));
+
+} // namespace autofill
« no previous file with comments | « ios/chrome/browser/autofill/form_input_egtest.mm ('k') | ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698