Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580253002:
Specify TaskType of posted Task explicitly in worker (7) (Closed)
|
Created:
4 years ago by tzik Modified:
4 years ago CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify TaskType of posted Task explicitly in worker
Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled
anyway. This CL assigns it as TaskType::Internal for now rather than
using TaskType::Unspecified.
BUG=624696
Committed: https://crrev.com/90e944766a9d44dc9243dbf53e2b12a43d37c28d
Cr-Commit-Position: refs/heads/master@{#439414}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : s/Unthrottled/Internal/ #
Messages
Total messages: 24 (16 generated)
Description was changed from ========== Specify TaskType of posted Task explicitly in worker (7) BUG= ========== to ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Unthrottled for now rather than using TaskType::Unspecified. BUG=624696 ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tzik@chromium.org changed reviewers: + haraken@chromium.org
PTAL
Can we use Internal unless the task is really an unthrottable one?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/18 14:55:48, haraken wrote: > Can we use Internal unless the task is really an unthrottable one? OK, done.
Description was changed from ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Unthrottled for now rather than using TaskType::Unspecified. BUG=624696 ========== to ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Internal for now rather than using TaskType::Unspecified. BUG=624696 ==========
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
nhiroki@chromium.org changed reviewers: + nhiroki@chromium.org
drive-by lgtm
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482124543857460,
"parent_rev": "f1f4adaf40c8b98dd52f8628b2e7b01b52cbc80b", "commit_rev":
"bcd93190881cac44e901437e132b2beb93f1318a"}
Message was sent while issue was closed.
Description was changed from ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Internal for now rather than using TaskType::Unspecified. BUG=624696 ========== to ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Internal for now rather than using TaskType::Unspecified. BUG=624696 Review-Url: https://codereview.chromium.org/2580253002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Internal for now rather than using TaskType::Unspecified. BUG=624696 Review-Url: https://codereview.chromium.org/2580253002 ========== to ========== Specify TaskType of posted Task explicitly in worker Workers doesn't have the scheduler in Blink. So, its tasks are unthrottled anyway. This CL assigns it as TaskType::Internal for now rather than using TaskType::Unspecified. BUG=624696 Committed: https://crrev.com/90e944766a9d44dc9243dbf53e2b12a43d37c28d Cr-Commit-Position: refs/heads/master@{#439414} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/90e944766a9d44dc9243dbf53e2b12a43d37c28d Cr-Commit-Position: refs/heads/master@{#439414} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
