Don't compile inner functions when compiling via the dispatcher

Don't compile inner functions when compiling via the dispatcher

BUG=v8:5394
R=mstarzinger@chromium.org,rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2579973002
Cr-Commit-Position: refs/heads/master@{#41754}
Committed: https://chromium.googlesource.com/v8/v8/+/87bf03379908c0b08eca85a0b3b64987c6d5eb9e

[jochen (gone - plz use gerrit), 2016-12-16 10:39:51]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 10:39:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 11:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 11:35:03]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-16 11:44:03]

LGTM from my end.

https://codereview.chromium.org/2579973002/diff/1/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2579973002/diff/1/src/compiler.h#newcode56
src/compiler.h:56: // Prepare a compilation job for unoptimized code. Requires
ParseAndAnalyse.
nit: Can we add a comment which explains that the {mode} parameter targets the
nested functions within the given compilation unit?

[jochen (gone - plz use gerrit), 2016-12-16 11:53:34]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 11:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-12-16 11:56:00]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-12-16 11:56:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2579973002/#ps20001
(title: "added comment")

[commit-bot: I haz the power, 2016-12-16 11:56:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:38:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481889360093780,
"parent_rev": "01408ea6532fb81750ab68729f1c503a7ad71d5e", "commit_rev":
"87bf03379908c0b08eca85a0b3b64987c6d5eb9e"}

[commit-bot: I haz the power, 2016-12-16 12:38:22]

Description was changed from

==========
Don't compile inner functions when compiling via the dispatcher

BUG=v8:5394
R=mstarzinger@chromium.org,rmcilroy@chromium.org
==========

to

==========
Don't compile inner functions when compiling via the dispatcher

BUG=v8:5394
R=mstarzinger@chromium.org,rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2579973002
Cr-Commit-Position: refs/heads/master@{#41754}
Committed:
https://chromium.googlesource.com/v8/v8/+/87bf03379908c0b08eca85a0b3b64987c6d...
==========

[commit-bot: I haz the power, 2016-12-16 12:38:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/87bf03379908c0b08eca85a0b3b64987c6d...

[rmcilroy, 2016-12-16 12:51:17]

https://codereview.chromium.org/2579973002/diff/20001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2579973002/diff/20001/src/compiler.h#newcode26
src/compiler.h:26: enum class LazyCompilationMode { kAlways, kIfRequested };
I find the name confusing, I parse the kAlways as always compile, not always
lazy compile AKA never compile.

How about naming this EagerInnerFunctionCompileMode { kIfRequested, kNever }?