Don't compile inner functions when compiling via the dispatcher

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include <memory>
 
 #include "src/allocation.h"
 #include "src/bailout-reason.h"
 #include "src/contexts.h"
 #include "src/isolate.h"
 #include "src/zone/zone.h"
 
 namespace v8 {
 namespace internal {
 
 // Forward declarations.
 class CompilationInfo;
 class CompilationJob;
 class JavaScriptFrame;
 class ParseInfo;
 class ScriptData;
 
+enum class LazyCompilationMode { kAlways, kIfRequested };
+
 // The V8 compiler API.
 //
 // This is the central hub for dispatching to the various compilers within V8.
 // Logic for which compiler to choose and how to wire compilation results into
 // the object heap should be kept inside this class.
 //
 // General strategy: Scripts are translated into anonymous functions w/o
 // parameters which then can be executed. If the source code contains other
 // functions, they might be compiled and allocated as part of the compilation
 // of the source code or deferred for lazy compilation at a later point.
 class Compiler : public AllStatic {
  public:
   enum ClearExceptionFlag { KEEP_EXCEPTION, CLEAR_EXCEPTION };
   enum ConcurrencyMode { NOT_CONCURRENT, CONCURRENT };
   enum CompilationTier { INTERPRETED, BASELINE, OPTIMIZED };
 
   // ===========================================================================
   // The following family of methods ensures a given function is compiled. The
   // general contract is that failures will be reported by returning {false},
   // whereas successful compilation ensures the {is_compiled} predicate on the
   // given function holds (except for live-edit, which compiles the world).
 
   static bool Compile(Handle<JSFunction> function, ClearExceptionFlag flag);
   static bool CompileBaseline(Handle<JSFunction> function);
   static bool CompileOptimized(Handle<JSFunction> function, ConcurrencyMode);
   static bool CompileDebugCode(Handle<SharedFunctionInfo> shared);
   static MaybeHandle<JSArray> CompileForLiveEdit(Handle<Script> script);
 
   // Prepare a compilation job for unoptimized code. Requires ParseAndAnalyse.

[Michael Starzinger, 2016/12/16 11:44:02]

nit: Can we add a comment which explains that the {mode} parameter targets the
nested functions within the given compilation unit?

   static CompilationJob* PrepareUnoptimizedCompilationJob(
-      CompilationInfo* info);
+      CompilationInfo* info, LazyCompilationMode mode);
 
   // Generate and install code from previously queued compilation job.
   static bool FinalizeCompilationJob(CompilationJob* job);
 
   // Give the compiler a chance to perform low-latency initialization tasks of
   // the given {function} on its instantiation. Note that only the runtime will
   // offer this chance, optimized closure instantiation will not call this.
   static void PostInstantiation(Handle<JSFunction> function, PretenureFlag);
 
   // Parser::Parse, then Compiler::Analyze.
@@ skipping 41 matching lines @@
       ScriptCompiler::CompileOptions compile_options,
       NativesFlag is_natives_code, bool is_module);
 
   // Create a shared function info object for a Script that has already been
   // parsed while the script was being loaded from a streamed source.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForStreamedScript(
       Handle<Script> script, ParseInfo* info, int source_length);
 
   // Create a shared function info object (the code may be lazily compiled).
   static Handle<SharedFunctionInfo> GetSharedFunctionInfo(
-      FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer);
+      FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer,
+      LazyCompilationMode mode = LazyCompilationMode::kIfRequested);
 
   // Create a shared function info object for a native function literal.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForNative(
       v8::Extension* extension, Handle<String> name);
 
   // ===========================================================================
   // The following family of methods provides support for OSR. Code generated
   // for entry via OSR might not be suitable for normal entry, hence will be
   // returned directly to the caller.
   //
@@ skipping 92 matching lines @@
       state_ = State::kFailed;
     }
     return status;
   }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_H_