Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2579973002: Don't compile inner functions when compiling via the dispatcher (Closed)
Patch Set: added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 void FullCodeGenerator::VisitFunctionDeclaration( 753 void FullCodeGenerator::VisitFunctionDeclaration(
754 FunctionDeclaration* declaration) { 754 FunctionDeclaration* declaration) {
755 VariableProxy* proxy = declaration->proxy(); 755 VariableProxy* proxy = declaration->proxy();
756 Variable* variable = proxy->var(); 756 Variable* variable = proxy->var();
757 switch (variable->location()) { 757 switch (variable->location()) {
758 case VariableLocation::UNALLOCATED: { 758 case VariableLocation::UNALLOCATED: {
759 globals_->Add(variable->name(), zone()); 759 globals_->Add(variable->name(), zone());
760 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 760 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
761 DCHECK(!slot.IsInvalid()); 761 DCHECK(!slot.IsInvalid());
762 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 762 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
763 Handle<SharedFunctionInfo> function = 763 Handle<SharedFunctionInfo> function = Compiler::GetSharedFunctionInfo(
764 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_); 764 declaration->fun(), script(), info_, compilation_mode_);
765 // Check for stack-overflow exception. 765 // Check for stack-overflow exception.
766 if (function.is_null()) return SetStackOverflow(); 766 if (function.is_null()) return SetStackOverflow();
767 globals_->Add(function, zone()); 767 globals_->Add(function, zone());
768 break; 768 break;
769 } 769 }
770 770
771 case VariableLocation::PARAMETER: 771 case VariableLocation::PARAMETER:
772 case VariableLocation::LOCAL: { 772 case VariableLocation::LOCAL: {
773 Comment cmnt(masm_, "[ FunctionDeclaration"); 773 Comment cmnt(masm_, "[ FunctionDeclaration");
774 VisitForAccumulatorValue(declaration->fun()); 774 VisitForAccumulatorValue(declaration->fun());
(...skipping 1995 matching lines...) Expand 10 before | Expand all | Expand 10 after
2770 DCHECK_EQ( 2770 DCHECK_EQ(
2771 isolate->builtins()->OnStackReplacement()->entry(), 2771 isolate->builtins()->OnStackReplacement()->entry(),
2772 Assembler::target_address_at(call_target_address, unoptimized_code)); 2772 Assembler::target_address_at(call_target_address, unoptimized_code));
2773 return ON_STACK_REPLACEMENT; 2773 return ON_STACK_REPLACEMENT;
2774 } 2774 }
2775 2775
2776 } // namespace internal 2776 } // namespace internal
2777 } // namespace v8 2777 } // namespace v8
2778 2778
2779 #endif // V8_TARGET_ARCH_X64 2779 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698