Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2579823002: Worker: Rename WorkletThreadHolder::threadHolderInstance() to getInstance() (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
falken, haraken
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, shimazu+worker_chromium.org, kinuko+worker_chromium.org, Raymond Toy, darktears, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, hongchan, blink-worker-reviews_chromium.org, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Rename WorkletThreadHolder::threadHolderInstance() to getInstance() This was raised in https://codereview.chromium.org/2582483002/#msg9 getInstance() would be more common name for a function to get a singleton instance and less confusing for code readers. BUG=n/a Committed: https://crrev.com/9ee1d8f40f0510ce61c7fce2c3ef24ee40326f12 Cr-Commit-Position: refs/heads/master@{#438984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletThreadHolder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp View 2 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
nhiroki
PTAL, thanks!
4 years ago (2016-12-15 16:37:25 UTC) #3
falken
thanks lgtm! this looks to match the ensureInstance and clearInstance functions too.
4 years ago (2016-12-16 01:09:17 UTC) #8
haraken
LGTM
4 years ago (2016-12-16 01:11:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579823002/1
4 years ago (2016-12-16 01:15:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 02:01:29 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 02:03:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ee1d8f40f0510ce61c7fce2c3ef24ee40326f12
Cr-Commit-Position: refs/heads/master@{#438984}

Powered by Google App Engine
This is Rietveld 408576698