third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp - Issue 2579823002: Worker: Rename WorkletThreadHolder::threadHolderInstance() to getInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp

Issue 2579823002: Worker: Rename WorkletThreadHolder::threadHolderInstance() to getInstance() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkletThreadHolder.h ('k') | third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp

index 2370da5dc7958b6e3a26d4293cb5cb647521fafe..72304649aaab487d9ac7fbcece28ed6423b13132 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp

@@ -25,8 +25,7 @@ AbstractAnimationWorkletThread::AbstractAnimationWorkletThread(

AbstractAnimationWorkletThread::~AbstractAnimationWorkletThread() {}

WorkerBackingThread& AbstractAnimationWorkletThread::workerBackingThread() {

- return *WorkletThreadHolder<

- AbstractAnimationWorkletThread>::threadHolderInstance()

+ return *WorkletThreadHolder<AbstractAnimationWorkletThread>::getInstance()

->thread();

}

@@ -38,12 +37,11 @@ void collectAllGarbageOnThread(WaitableEvent* doneEvent) {

void AbstractAnimationWorkletThread::collectAllGarbage() {

DCHECK(isMainThread());

WaitableEvent doneEvent;

- WorkletThreadHolder<AbstractAnimationWorkletThread>* threadHolderInstance =

- WorkletThreadHolder<

- AbstractAnimationWorkletThread>::threadHolderInstance();

- if (!threadHolderInstance)

+ WorkletThreadHolder<AbstractAnimationWorkletThread>* workletThreadHolder =

+ WorkletThreadHolder<AbstractAnimationWorkletThread>::getInstance();

+ if (!workletThreadHolder)

return;

- threadHolderInstance->thread()->backingThread().postTask(

+ workletThreadHolder->thread()->backingThread().postTask(

BLINK_FROM_HERE, crossThreadBind(&collectAllGarbageOnThread,

crossThreadUnretained(&doneEvent)));

doneEvent.wait();