Worker: Enable UseCounter for ThreadedWorkletGlobalScope

Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org

Committed: https://crrev.com/3a6310b801c1b5d36c887cdbdd3528ed80867554
Cr-Commit-Position: refs/heads/master@{#438874}

[nhiroki, 2016-12-15 14:53:48]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:53:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-15 15:24:32]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2016-12-15 15:24:43]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-15 15:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-15 15:24:56]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-12-15 15:25:27]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2016-12-15 15:25:27]

PTAL, thanks!

[falken, 2016-12-15 15:54:35]

lgtm

https://codereview.chromium.org/2582483002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp (right):

https://codereview.chromium.org/2582483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp:32:
ThreadedWorkletThreadForTest>::threadHolderInstance();
really nitty: I think it's a reasonable use of |auto| but the way the variables
and function names are written makes me feel "WorkerThreadHolderInstance" or
"ThreadHolderInstance" could be types different from "WorkletThreadHolder". 
Maybe threadHolderInstance should just be threadHolder or workletThreadHolder.

It feels threadHolderInstance could have been named getInstance?

[nhiroki, 2016-12-15 16:16:42]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2016-12-15 16:17:04]

Thank you!

https://codereview.chromium.org/2582483002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp (right):

https://codereview.chromium.org/2582483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp:32:
ThreadedWorkletThreadForTest>::threadHolderInstance();
On 2016/12/15 15:54:35, falken wrote:
> really nitty: I think it's a reasonable use of |auto| but the way the
variables
> and function names are written makes me feel "WorkerThreadHolderInstance" or
> "ThreadHolderInstance" could be types different from "WorkletThreadHolder". 
> Maybe threadHolderInstance should just be threadHolder or workletThreadHolder.

Renamed this to "workletThreadHolder".

> It feels threadHolderInstance could have been named getInstance?

I'll make a separate CL to rename it.

[commit-bot: I haz the power, 2016-12-15 16:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-15 16:18:06]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2016-12-15 16:19:33]

Description was changed from

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
==========

to

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org
==========

[nhiroki, 2016-12-15 16:19:33]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2016-12-15 16:20:25]

+haraken for BUILD.gn.

Let me use TBR because BUILD.gn has only one line change to add one test file.

[nhiroki, 2016-12-15 16:20:31]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-12-15 16:20:32]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2582483002/#ps60001
(title: "rename threadHolderInstance to workletThreadHolder")

[commit-bot: I haz the power, 2016-12-15 16:20:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-15 17:37:40]

LGTM

[commit-bot: I haz the power, 2016-12-15 18:09:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481818831783720,
"parent_rev": "88fa064e9eda43990f7c393ea8c713bdb1e2084a", "commit_rev":
"0b1130efed5c60c82325e728f66c562436bac066"}

[commit-bot: I haz the power, 2016-12-15 18:10:12]

Description was changed from

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org
==========

to

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2582483002
==========

[commit-bot: I haz the power, 2016-12-15 18:10:13]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-12-15 18:12:03]

Description was changed from

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2582483002
==========

to

==========
Worker: Enable UseCounter for ThreadedWorkletGlobalScope

API use on the ThreadedWorkletGlobalScope is recorded in parent Document's
UseCounter.

Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this
should not affect use counts in the real world.

BUG=667357
TBR=haraken@chromium.org

Committed: https://crrev.com/3a6310b801c1b5d36c887cdbdd3528ed80867554
Cr-Commit-Position: refs/heads/master@{#438874}
==========

[commit-bot: I haz the power, 2016-12-15 18:12:03]

Patchset 2 (id:??) landed as
https://crrev.com/3a6310b801c1b5d36c887cdbdd3528ed80867554
Cr-Commit-Position: refs/heads/master@{#438874}