LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org

Committed: https://crrev.com/d20ec3c985ef745d0069e9b12b0e10d10f1bdb80
Cr-Commit-Position: refs/heads/master@{#439027}

[Tom (Use chromium acct), 2016-12-15 03:23:04]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 03:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 03:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 03:28:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-12-15 18:24:28]

lgtm

[Tom (Use chromium acct), 2016-12-15 19:06:07]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-12-15 19:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2579683002/#ps20001
(title: "Fix gn check")

[commit-bot: I haz the power, 2016-12-15 19:06:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 20:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 20:35:50]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom (Use chromium acct), 2016-12-16 01:13:33]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 01:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:55:42]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-12-16 04:05:37]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-12-16 04:05:38]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2579683002/#ps40001
(title: "Fix lsan error")

[commit-bot: I haz the power, 2016-12-16 04:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:53:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481861137877470,
"parent_rev": "54a9d1ee23facff721ce53f05b9b3394fd2413c9", "commit_rev":
"c7e7587dbdb21e1e8dde4bcbdc80eded8c12e7f4"}

[commit-bot: I haz the power, 2016-12-16 04:54:15]

Description was changed from

==========
LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org
==========

to

==========
LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2579683002
==========

[commit-bot: I haz the power, 2016-12-16 04:54:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-16 04:58:28]

Description was changed from

==========
LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2579683002
==========

to

==========
LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3

When complete, the Gtk3 theming code will look completely different
from the Gtk2 code.  This CL splits out NativeThemeGtk in preparation
of this change.

The planned change for gtk3 is to use foreign drawing (see
gtk/demos/gtk-demo/foreigndrawing.c) to provide an implementation of
NativeTheme::GetPartSize and NativeTheme::Paint*.

The Gtk2 theme will continue to use the NativeThemeBase
implementations of these functions while just supplying basic colors.

BUG=132847
R=erg@chromium.org

Committed: https://crrev.com/d20ec3c985ef745d0069e9b12b0e10d10f1bdb80
Cr-Commit-Position: refs/heads/master@{#439027}
==========

[commit-bot: I haz the power, 2016-12-16 04:58:29]

Patchset 3 (id:??) landed as
https://crrev.com/d20ec3c985ef745d0069e9b12b0e10d10f1bdb80
Cr-Commit-Position: refs/heads/master@{#439027}