Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Side by Side Diff: chrome/browser/ui/libgtkui/BUILD.gn

Issue 2579683002: LibGtkUi: Partition NativeThemeGtk into NativeThemeGtk2 and NativeThemeGtk3 (Closed)
Patch Set: Fix lsan error Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/libgtkui/gtk_ui.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(is_linux, "This file should only be referenced on Linux") 5 assert(is_linux, "This file should only be referenced on Linux")
6 6
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/linux/gtk/gtk.gni") 8 import("//build/config/linux/gtk/gtk.gni")
9 import("//printing/features/features.gni") 9 import("//printing/features/features.gni")
10 10
(...skipping 28 matching lines...) Expand all
39 "gtk_key_bindings_handler.h", 39 "gtk_key_bindings_handler.h",
40 "gtk_status_icon.cc", 40 "gtk_status_icon.cc",
41 "gtk_status_icon.h", 41 "gtk_status_icon.h",
42 "gtk_ui.cc", 42 "gtk_ui.cc",
43 "gtk_ui.h", 43 "gtk_ui.h",
44 "gtk_util.cc", 44 "gtk_util.cc",
45 "gtk_util.h", 45 "gtk_util.h",
46 "libgtkui_export.h", 46 "libgtkui_export.h",
47 "menu_util.cc", 47 "menu_util.cc",
48 "menu_util.h", 48 "menu_util.h",
49 "native_theme_gtk.cc",
50 "native_theme_gtk.h",
51 "print_dialog_gtk.cc", 49 "print_dialog_gtk.cc",
52 "print_dialog_gtk.h", 50 "print_dialog_gtk.h",
53 "printing_gtk_util.cc", 51 "printing_gtk_util.cc",
54 "printing_gtk_util.h", 52 "printing_gtk_util.h",
55 "select_file_dialog_impl.cc", 53 "select_file_dialog_impl.cc",
56 "select_file_dialog_impl.h", 54 "select_file_dialog_impl.h",
57 "select_file_dialog_impl_gtk.cc", 55 "select_file_dialog_impl_gtk.cc",
58 "select_file_dialog_impl_gtk.h", 56 "select_file_dialog_impl_gtk.h",
59 "select_file_dialog_impl_kde.cc", 57 "select_file_dialog_impl_kde.cc",
60 "skia_utils_gtk.cc", 58 "skia_utils_gtk.cc",
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 ":libgtk3ui", 120 ":libgtk3ui",
123 ] 121 ]
124 } else { 122 } else {
125 public_deps = [ 123 public_deps = [
126 ":libgtk2ui", 124 ":libgtk2ui",
127 ] 125 ]
128 } 126 }
129 } 127 }
130 128
131 component("libgtk2ui") { 129 component("libgtk2ui") {
132 sources = common_sources 130 sources = common_sources + [
131 "native_theme_gtk2.cc",
132 "native_theme_gtk2.h",
133 ]
133 configs += common_configs 134 configs += common_configs
134 defines = [ "LIBGTKUI_IMPLEMENTATION" ] 135 defines = [ "LIBGTKUI_IMPLEMENTATION" ]
135 136
136 # GTK2 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz. 137 # GTK2 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz.
137 # To avoid missing indirectly referenced harfbuzz symbols from pango, 138 # To avoid missing indirectly referenced harfbuzz symbols from pango,
138 # some hack is required when bundled harfbuzz is used and component build is 139 # some hack is required when bundled harfbuzz is used and component build is
139 # disabled. 140 # disabled.
140 # See crbug.com/462689 for details. 141 # See crbug.com/462689 for details.
141 all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ] 142 all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
142 143
143 deps = common_deps + [ 144 deps = common_deps + [
144 "//build/config/linux/gtk2", 145 "//build/config/linux/gtk2",
145 "//build/config/linux/gtk2:gtkprint2", 146 "//build/config/linux/gtk2:gtkprint2",
146 ] 147 ]
147 public_deps = [ 148 public_deps = [
148 "//chrome/browser:theme_properties", 149 "//chrome/browser:theme_properties",
149 ] 150 ]
150 } 151 }
151 152
152 # This is compiled with "all" even when it's not referenced to ensure that 153 # This is compiled with "all" even when it's not referenced to ensure that
153 # GTK3 continues to build. GTK3 is explicitly specified by some distros. 154 # GTK3 continues to build. GTK3 is explicitly specified by some distros.
154 component("libgtk3ui") { 155 component("libgtk3ui") {
155 sources = common_sources 156 sources = common_sources + [
157 "native_theme_gtk3.cc",
158 "native_theme_gtk3.h",
159 ]
156 configs += common_configs 160 configs += common_configs
157 defines = [ "LIBGTKUI_IMPLEMENTATION" ] 161 defines = [ "LIBGTKUI_IMPLEMENTATION" ]
158 162
159 deps = common_deps + [ 163 deps = common_deps + [
160 "//build/config/linux/gtk3", 164 "//build/config/linux/gtk3",
161 "//build/config/linux/gtk3:gtkprint3", 165 "//build/config/linux/gtk3:gtkprint3",
162 ] 166 ]
163 public_deps = [ 167 public_deps = [
164 "//chrome/browser:theme_properties", 168 "//chrome/browser:theme_properties",
165 ] 169 ]
166 } 170 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/libgtkui/gtk_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698