Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2579223002: Gtk3: Add foreign-drawing for menus (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Add foreign-drawing for menus BUG=132847 R=erg@chromium.org Committed: https://crrev.com/efbeecb00d538cde3f96ba61e0ea299f7c9a3ec0 Cr-Commit-Position: refs/heads/master@{#439171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M chrome/browser/ui/libgtkui/native_theme_gtk3.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 3 chunks +75 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Tom (Use chromium acct)
4 years ago (2016-12-16 02:05:41 UTC) #1
Elliot Glaysher
Neat! LGTM
4 years ago (2016-12-16 19:09:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579223002/1
4 years ago (2016-12-16 19:14:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 20:00:57 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-16 20:03:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efbeecb00d538cde3f96ba61e0ea299f7c9a3ec0
Cr-Commit-Position: refs/heads/master@{#439171}

Powered by Google App Engine
This is Rietveld 408576698