Update paint properties on FrameView visibility changes

Update paint properties on FrameView visibility changes

When a FrameView becomes hidden, we need to update scroll paint properties to
ensure scrollability based on hit testing is accounted for. This patch fixes
the FrameView-specific bug. https://crbug.com/675296 has been filed to
address stale scrollability values which is a remaining bug for LayoutView.

TEST=scrollingcoordinator/non-fast-scrollable-visibility-change.html with
--additional-driver-flag=--enable-slimming-paint-invalidation

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1748a4cf3fb64dac6d739f61892711d209530ccf
Cr-Commit-Position: refs/heads/master@{#439317}

[pdr., 2016-12-17 02:23:32]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[pdr., 2016-12-17 02:23:39]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 02:24:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-17 02:25:39]

lgtm.

Which tests pass with this CL?

[pdr., 2016-12-17 02:27:35]

On 2016/12/17 at 02:25:39, wangxianzhu wrote:
> lgtm.
> 
> Which tests pass with this CL?

Only scrollingcoordinator/non-fast-scrollable-visibility-change.html from the
spreadsheet.

I have a unittest but if fails due to https://crbug.com/675296. I'll go ahead
and add it but mark it as disabled.

[pdr., 2016-12-17 02:33:13]

On 2016/12/17 at 02:27:35, pdr. wrote:
> On 2016/12/17 at 02:25:39, wangxianzhu wrote:
> > lgtm.
> > 
> > Which tests pass with this CL?
> 
> Only scrollingcoordinator/non-fast-scrollable-visibility-change.html from the
spreadsheet.
> 
> I have a unittest but if fails due to https://crbug.com/675296. I'll go ahead
and add it but mark it as disabled.

Updated, PTAL

[Xianzhu, 2016-12-17 02:34:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-17 02:34:48]

lgtm

[commit-bot: I haz the power, 2016-12-17 02:35:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 04:24:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481942087940870,
"parent_rev": "86db03c43c813136c06cf6bbe532d93acec524cd", "commit_rev":
"050d84f1d9a5742d48259f0da331a997b695b209"}

[commit-bot: I haz the power, 2016-12-17 04:24:44]

Description was changed from

==========
Update paint properties on FrameView visibility changes

When a FrameView becomes hidden, we need to update scroll paint properties to
ensure scrollability based on hit testing is accounted for. This patch fixes
the FrameView-specific bug. https://crbug.com/675296 has been filed to
address stale scrollability values which is a remaining bug for LayoutView.

TEST=scrollingcoordinator/non-fast-scrollable-visibility-change.html with
--additional-driver-flag=--enable-slimming-paint-invalidation

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update paint properties on FrameView visibility changes

When a FrameView becomes hidden, we need to update scroll paint properties to
ensure scrollability based on hit testing is accounted for. This patch fixes
the FrameView-specific bug. https://crbug.com/675296 has been filed to
address stale scrollability values which is a remaining bug for LayoutView.

TEST=scrollingcoordinator/non-fast-scrollable-visibility-change.html with
--additional-driver-flag=--enable-slimming-paint-invalidation

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2579363003
==========

[commit-bot: I haz the power, 2016-12-17 04:24:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-17 04:27:22]

Description was changed from

==========
Update paint properties on FrameView visibility changes

When a FrameView becomes hidden, we need to update scroll paint properties to
ensure scrollability based on hit testing is accounted for. This patch fixes
the FrameView-specific bug. https://crbug.com/675296 has been filed to
address stale scrollability values which is a remaining bug for LayoutView.

TEST=scrollingcoordinator/non-fast-scrollable-visibility-change.html with
--additional-driver-flag=--enable-slimming-paint-invalidation

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2579363003
==========

to

==========
Update paint properties on FrameView visibility changes

When a FrameView becomes hidden, we need to update scroll paint properties to
ensure scrollability based on hit testing is accounted for. This patch fixes
the FrameView-specific bug. https://crbug.com/675296 has been filed to
address stale scrollability values which is a remaining bug for LayoutView.

TEST=scrollingcoordinator/non-fast-scrollable-visibility-change.html with
--additional-driver-flag=--enable-slimming-paint-invalidation

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1748a4cf3fb64dac6d739f61892711d209530ccf
Cr-Commit-Position: refs/heads/master@{#439317}
==========

[commit-bot: I haz the power, 2016-12-17 04:27:22]

Patchset 2 (id:??) landed as
https://crrev.com/1748a4cf3fb64dac6d739f61892711d209530ccf
Cr-Commit-Position: refs/heads/master@{#439317}