Update paint properties on FrameView visibility changes

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/HTMLIFrameElement.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintPropertyTreePrinter.h"
@@ skipping 45 matching lines @@
     return frameView->scrollTranslation();
   }
 
   const ClipPaintPropertyNode* frameContentClip() {
     FrameView* frameView = document().view();
     if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
       return frameView->layoutView()->paintProperties()->overflowClip();
     return frameView->contentClip();
   }
 
-  const ScrollPaintPropertyNode* frameScroll() {
-    FrameView* frameView = document().view();
+  const ScrollPaintPropertyNode* frameScroll(FrameView* frameView = nullptr) {
+    if (!frameView)
+      frameView = document().view();
     if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
       return frameView->layoutView()->paintProperties()->scroll();
     return frameView->scroll();
   }
 
   LayoutPoint paintOffset(const LayoutObject* object) {
     return object->paintProperties()->localBorderBoxProperties()->paintOffset;
   }
 
  private:
@@ skipping 3146 matching lines @@
 TEST_P(PaintPropertyTreeBuilderTest, NoPaintPropertyUpdateOnBackgroundChange) {
   setBodyInnerHTML("<div id='div' style='background-color: blue'>DIV</div>");
   auto* div = document().getElementById("div");
 
   document().view()->updateAllLifecyclePhases();
   div->setAttribute(HTMLNames::styleAttr, "background-color: green");
   document().view()->updateLifecycleToLayoutClean();
   EXPECT_FALSE(div->layoutObject()->needsPaintPropertyUpdate());
 }
 
+// Disabled due to stale scrollsOverflow values, see: https://crbug.com/675296.
+TEST_P(PaintPropertyTreeBuilderTest,
+       DISABLED_FrameVisibilityChangeUpdatesProperties) {
+  setBodyInnerHTML(
+      "<style>body { margin: 0; }</style>"
+      "<div id='iframeContainer'>"
+      "  <iframe id='iframe' style='width: 100px; height: 100px;'></iframe>"
+      "</div>");
+  setChildFrameHTML(
+      "<style>body { margin: 0; }</style>"
+      "<div id='forceScroll' style='height: 3000px;'></div>");
+
+  FrameView* frameView = document().view();
+  frameView->updateAllLifecyclePhases();
+  EXPECT_EQ(nullptr, frameScroll(frameView));
+  FrameView* childFrameView = childDocument().view();
+  EXPECT_NE(nullptr, frameScroll(childFrameView));
+
+  auto* iframeContainer = document().getElementById("iframeContainer");
+  iframeContainer->setAttribute(HTMLNames::styleAttr, "visibility: hidden;");
+  frameView->updateAllLifecyclePhases();
+
+  EXPECT_EQ(nullptr, frameScroll(frameView));
+  EXPECT_EQ(nullptr, frameScroll(childFrameView));
+}
+
 }  // namespace blink