Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2579363003: Update paint properties on FrameView visibility changes (Closed)
Patch Set: Add unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 0c7d4f33b61ec7012e09c88861a90ec23c3fdbd6..e3ac2b8c1115b9edba4b193e6ef9a1cc971948ea 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -4427,6 +4427,11 @@ void FrameView::show() {
scrollingCoordinator->frameViewVisibilityDidChange();
setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree);
updateParentScrollableAreaSet();
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
+ // The existance of scrolling properties depends on visibility through
+ // isScrollable() so ensure properties are updated if visibility changes.
+ setNeedsPaintPropertyUpdate();
+ }
if (isParentVisible()) {
for (const auto& child : m_children)
child->setParentVisible(true);
@@ -4448,6 +4453,11 @@ void FrameView::hide() {
scrollingCoordinator->frameViewVisibilityDidChange();
setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree);
updateParentScrollableAreaSet();
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
+ // The existance of scrolling properties depends on visibility through
+ // isScrollable() so ensure properties are updated if visibility changes.
+ setNeedsPaintPropertyUpdate();
+ }
}
Widget::hide();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698