Gtk3: Fix various menu colors

Gtk3: Fix various menu colors

BUG=132847
R=erg@chromium.org

Committed: https://crrev.com/82531759b80d7dc04ab799d921c6eeabb0f7d411
Cr-Commit-Position: refs/heads/master@{#439216}

[Tom (Use chromium acct), 2016-12-16 21:48:14]

This should fix most wonky colors on menus, except for subtitles.

Chrome uses the same color for menu subtitles as for a disabled button:
https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_item_view.cc...
But on Adwaita that happens to be the same color as a menu background, so
subtitles appear invisible.  I'll just add a new color id in a followup CL to
fix.

[Elliot Glaysher, 2016-12-16 21:55:59]

lgtm

https://codereview.chromium.org/2585893002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right):

https://codereview.chromium.org/2585893002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/native_theme_gtk3.cc:84: SkColor GetFGColor(const
char* css_selector, GtkStateFlags state) {
Do you plan on having two GetFBColor functions overloaded by type for the long
run, or is this a short term thing while you convert away other
GetFGColor(GtkWidget*, WidgetState) usage?

[Tom (Use chromium acct), 2016-12-16 22:01:07]

https://codereview.chromium.org/2585893002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right):

https://codereview.chromium.org/2585893002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/native_theme_gtk3.cc:84: SkColor GetFGColor(const
char* css_selector, GtkStateFlags state) {
On 2016/12/16 21:55:59, Elliot Glaysher wrote:
> Do you plan on having two GetFBColor functions overloaded by type for the long
> run, or is this a short term thing while you convert away other
> GetFGColor(GtkWidget*, WidgetState) usage?

Just temporary during the conversion

[Tom (Use chromium acct), 2016-12-16 22:01:11]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-12-16 22:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:20:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481925671765810, "parent_rev":
"59cde8f5500a5ad592a9df02cfd64c8606b9132d", "commit_rev":
"cc33e676471ddf8f37ed2896808426cef8178935"}

[commit-bot: I haz the power, 2016-12-16 22:21:11]

Description was changed from

==========
Gtk3: Fix various menu colors

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix various menu colors

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2585893002
==========

[commit-bot: I haz the power, 2016-12-16 22:21:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 22:25:16]

Description was changed from

==========
Gtk3: Fix various menu colors

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2585893002
==========

to

==========
Gtk3: Fix various menu colors

BUG=132847
R=erg@chromium.org

Committed: https://crrev.com/82531759b80d7dc04ab799d921c6eeabb0f7d411
Cr-Commit-Position: refs/heads/master@{#439216}
==========

[commit-bot: I haz the power, 2016-12-16 22:25:17]

Patchset 1 (id:??) landed as
https://crrev.com/82531759b80d7dc04ab799d921c6eeabb0f7d411
Cr-Commit-Position: refs/heads/master@{#439216}