Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2578913002: Unify animate motion transform update invalidations (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
fs
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify animate motion transform update invalidations SVGAnimateMotionElement changes transforms in 3 locations but does not notify the targets of transform updates in a unified way. For example, target->setNeedsTransformUpdate is called when the transform changes but the target is not marked for layout until applyResultsToTarget. This patch unifies these invalidations to always occur when the tranform is updated. The previous code dates back to http://wkbug.com/41249. BUG=645667 Committed: https://crrev.com/174b75c4971ebe89bf055b824c9c5ef0d5a75aee Cr-Commit-Position: refs/heads/master@{#438841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp View 5 chunks +11 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
fs
Don't know if you had intended to publish this, but this looks like it would ...
4 years ago (2016-12-15 08:13:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578913002/1
4 years ago (2016-12-15 16:09:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 16:13:56 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 16:16:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/174b75c4971ebe89bf055b824c9c5ef0d5a75aee
Cr-Commit-Position: refs/heads/master@{#438841}

Powered by Google App Engine
This is Rietveld 408576698