Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2577993003:
Update paint properties on animate motion transform updates (Closed)
|
Created:
4 years ago by pdr. Modified:
4 years ago CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate paint properties on animate motion transform updates
This patch updates SVGAnimateMotionElement so that changes to the
animate motion transform call setNeedsPaintPropertyUpdate. A followup
patch will unify the behavior of the setNeedsTransformUpdate() calls.
With this patch and --enable-blink-features=SlimmingPaintInvalidation,
new tests pass:
svg/animations/animateMotion-fill-freeze.html
svg/animations/animateMotion-fill-remove.html
svg/animations/animateMotion_changingPath.html
+7 more
BUG=645667
Committed: https://crrev.com/cf47f9aef168366be06e398aa28b697303fd90ed
Cr-Commit-Position: refs/heads/master@{#438915}
Patch Set 1 #Patch Set 2 : Add missing object. #
Depends on Patchset: Messages
Total messages: 21 (13 generated)
pdr@chromium.org changed reviewers: + fs@opera.com, wangxianzhu@chromium.org
Description was changed from ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, the following tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html BUG=645667 ========== to ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, new tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html +7 more BUG=645667 ==========
lgtm
The CQ bit was checked by pdr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2578913002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481829957319860,
"parent_rev": "10a81701a8a9a4d9e9deacc1f7a4a7c28f1c6baf", "commit_rev":
"3eea1bfe8f22c44537e9a94d2a623b63466b90fa"}
Message was sent while issue was closed.
Description was changed from ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, new tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html +7 more BUG=645667 ========== to ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, new tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html +7 more BUG=645667 Review-Url: https://codereview.chromium.org/2577993003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, new tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html +7 more BUG=645667 Review-Url: https://codereview.chromium.org/2577993003 ========== to ========== Update paint properties on animate motion transform updates This patch updates SVGAnimateMotionElement so that changes to the animate motion transform call setNeedsPaintPropertyUpdate. A followup patch will unify the behavior of the setNeedsTransformUpdate() calls. With this patch and --enable-blink-features=SlimmingPaintInvalidation, new tests pass: svg/animations/animateMotion-fill-freeze.html svg/animations/animateMotion-fill-remove.html svg/animations/animateMotion_changingPath.html +7 more BUG=645667 Committed: https://crrev.com/cf47f9aef168366be06e398aa28b697303fd90ed Cr-Commit-Position: refs/heads/master@{#438915} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cf47f9aef168366be06e398aa28b697303fd90ed Cr-Commit-Position: refs/heads/master@{#438915} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
