Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2578473003: Remove more unused widget styles (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove more unused widget styles Remove more FWL Widget Styles which are never set. Review-Url: https://codereview.chromium.org/2578473003 Committed: https://pdfium.googlesource.com/pdfium/+/d92477068ad0918c97a5dab799d8cfdf07ce3580

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -68 lines) Patch
M xfa/fde/tto/fde_textout.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fwl/cfwl_checkbox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_edit.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_form.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/cfwl_listbox.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/fwl/cfwl_pushbutton.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_widget.cpp View 2 chunks +1 line, -20 lines 0 comments Download
M xfa/fwl/cfwl_widgetmgr.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/fwl_widgetdef.h View 1 chunk +0 lines, -19 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dsinclair
PTAL.
4 years ago (2016-12-14 16:44:30 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-14 17:32:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578473003/60001
4 years ago (2016-12-15 21:43:19 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 21:43:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/d92477068ad0918c97a5dab799d8cfdf07ce...

Powered by Google App Engine
This is Rietveld 408576698