Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2573133002: Remove unused widget state flags (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused widget state flags These widget state flags are not set and mostly unused. Removed. Review-Url: https://codereview.chromium.org/2573133002 Committed: https://pdfium.googlesource.com/pdfium/+/791a0ccd25474d9306ad0df425575869caec3048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M xfa/fwl/cfwl_edit.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M xfa/fwl/cfwl_form.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_themepart.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/cfwl_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/cfwl_widget.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/fwl_widgetdef.h View 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (10 generated)
dsinclair
PTAL.
4 years ago (2016-12-14 16:28:38 UTC) #2
Tom Sepez
https://codereview.chromium.org/2573133002/diff/1/xfa/fwl/fwl_widgetdef.h File xfa/fwl/fwl_widgetdef.h (right): https://codereview.chromium.org/2573133002/diff/1/xfa/fwl/fwl_widgetdef.h#newcode37 xfa/fwl/fwl_widgetdef.h:37: #define FWL_WGTSTYLE_WindowTypeMask (3L << 0) this can probably go, ...
4 years ago (2016-12-14 17:31:11 UTC) #3
dsinclair
https://codereview.chromium.org/2573133002/diff/1/xfa/fwl/fwl_widgetdef.h File xfa/fwl/fwl_widgetdef.h (right): https://codereview.chromium.org/2573133002/diff/1/xfa/fwl/fwl_widgetdef.h#newcode37 xfa/fwl/fwl_widgetdef.h:37: #define FWL_WGTSTYLE_WindowTypeMask (3L << 0) On 2016/12/14 17:31:11, Tom ...
4 years ago (2016-12-14 17:49:34 UTC) #4
dsinclair
ping
4 years ago (2016-12-15 13:59:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573133002/60001
4 years ago (2016-12-15 18:32:47 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-15 18:32:49 UTC) #13
Tom Sepez
lgtm
4 years ago (2016-12-15 21:02:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573133002/60001
4 years ago (2016-12-15 21:42:37 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-15 21:42:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/791a0ccd25474d9306ad0df425575869caec...

Powered by Google App Engine
This is Rietveld 408576698