Mojo JS bindings: BindingSet support.

Mojo JS bindings: BindingSet support.

It also makes binding to a raw handle easier.

BUG=579646
Committed: https://crrev.com/0c641b54f863dca5fdd30c5e5375af919157d891
Cr-Commit-Position: refs/heads/master@{#438973}

[yzshen1, 2016-12-15 22:42:20]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-12-15 22:43:29]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-12-15 22:43:30]

Hi, Ken.

Would you please take a look? Thanks!

[Ken Rockot(use gerrit already), 2016-12-15 23:20:00]

lgtm

[yzshen1, 2016-12-15 23:28:58]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2016-12-15 23:28:58]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:09:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481844538922340, "parent_rev":
"6b53cbd16eddec32887334984d488cd81e84adb9", "commit_rev":
"8d557ee3314287124d808d80254bf2c56a24924c"}

[commit-bot: I haz the power, 2016-12-16 01:10:49]

Description was changed from

==========
Mojo JS bindings: BindingSet support.

It also makes binding to a raw handle easier.

BUG=579646
==========

to

==========
Mojo JS bindings: BindingSet support.

It also makes binding to a raw handle easier.

BUG=579646

Review-Url: https://codereview.chromium.org/2578333002
==========

[commit-bot: I haz the power, 2016-12-16 01:10:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 01:13:27]

Description was changed from

==========
Mojo JS bindings: BindingSet support.

It also makes binding to a raw handle easier.

BUG=579646

Review-Url: https://codereview.chromium.org/2578333002
==========

to

==========
Mojo JS bindings: BindingSet support.

It also makes binding to a raw handle easier.

BUG=579646

Committed: https://crrev.com/0c641b54f863dca5fdd30c5e5375af919157d891
Cr-Commit-Position: refs/heads/master@{#438973}
==========

[commit-bot: I haz the power, 2016-12-16 01:13:28]

Patchset 1 (id:??) landed as
https://crrev.com/0c641b54f863dca5fdd30c5e5375af919157d891
Cr-Commit-Position: refs/heads/master@{#438973}

[rohitrao (ping after 24h), 2016-12-16 04:43:44]

This may have triggered failures on iOS in WebUIMojoTest.MessageExchange.

The crash stack below is not the actual error, that's just a timeout firing and
CHECKing.  I think the actual errors are:

JavaScript error: SyntaxError: Unexpected token ')' URL:testwebui://testwebui/
JavaScript error: Error: Load timeout for modules: mojo/public/js/bindings,main

https://build.chromium.org/p/chromium.fyi/builders/ios-simulator/builds/85/st...


[----------] 1 test from WebUIMojoTest
[ RUN      ] WebUIMojoTest.MessageExchange
[INFO] GCDWebServer started on port 8080 and reachable at
http://192.168.148.80:8080/
[INFO] GCDWebServer now reachable at http://build802-m4.local:8080/
[4813:1803:1215/174621.086651:4837009997990:ERROR:crw_web_controller.mm(3044)]
JavaScript error: SyntaxError: Unexpected token ')' URL:testwebui://testwebui/
[4813:1803:1215/174629.081514:4845004679588:ERROR:crw_web_controller.mm(3044)]
JavaScript error: Error: Load timeout for modules: mojo/public/js/bindings,main
http://requirejs.org/docs/errors.html#timeout URL:testwebui://testwebui/
[4813:1803:1215/174630.466389:4846389453002:FATAL:wait_util.mm(40)] Check
failed: !condition || condition_evaluation_result.
0   ios_web_inttests                    0x0000000100bb2f0e
_ZN4base5debug10StackTraceC2Ev + 30
1   ios_web_inttests                    0x0000000100bb2f75
_ZN4base5debug10StackTraceC1Ev + 21
2   ios_web_inttests                    0x0000000100c20160
_ZN7logging10LogMessageD2Ev + 80
3   ios_web_inttests                    0x0000000100c1de55
_ZN7logging10LogMessageD1Ev + 21
4   ios_web_inttests                    0x0000000100a3225f
_ZN4base4test3ios18TimeUntilConditionEU13block_pointerFvvEU13block_pointerFbvEbNS_9TimeDeltaE
+ 751
5   ios_web_inttests                    0x0000000100a325a8
_ZN4base4test3ios18WaitUntilConditionEU13block_pointerFbvEbNS_9TimeDeltaE + 72
6   ios_web_inttests                    0x0000000100a32636
_ZN4base4test3ios18WaitUntilConditionEU13block_pointerFbvEPNS_11MessageLoopENS_9TimeDeltaE
+ 54
7   ios_web_inttests                    0x0000000100a325f1
_ZN4base4test3ios18WaitUntilConditionEU13block_pointerFbvE + 49
8   ios_web_inttests                    0x00000001006ab0f6
_ZN3web34WebUIMojoTest_MessageExchange_Test8TestBodyEv + 534
9   ios_web_inttests                    0x0000000100b71bae
_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
+ 126
10  ios_web_inttests                    0x0000000100b3f912
_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
+ 114
11  ios_web_inttests                    0x0000000100b3f846
_ZN7testing4Test3RunEv + 198
12  ios_web_inttests                    0x0000000100b4187d
_ZN7testing8TestInfo3RunEv + 221
13  ios_web_inttests                    0x0000000100b431fc
_ZN7testing8TestCase3RunEv + 236
14  ios_web_inttests                    0x0000000100b58999
_ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 873
15  ios_web_inttests                    0x0000000100b74a5e
_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+ 126
16  ios_web_inttests                    0x0000000100b585b2
_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+ 114
17  ios_web_inttests                    0x0000000100b584a5
_ZN7testing8UnitTest3RunEv + 373
18  ios_web_inttests                    0x0000000100a33811 _Z13RUN_ALL_TESTSv +
17
19  ios_web_inttests                    0x0000000100a32d5a
_ZN4base9TestSuite3RunEv + 330
20  ios_web_inttests                    0x0000000100a3682c
-[ChromeUnitTestDelegate runTests] + 28
21  Foundation                          0x000000010636f129
__NSFireDelayedPerform + 402
22  CoreFoundation                      0x0000000105ae6364
__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
23  CoreFoundation                      0x0000000105ae5f11 __CFRunLoopDoTimer +
1089
24  CoreFoundation                      0x0000000105aa78b1 __CFRunLoopRun + 1937
25  CoreFoundation                      0x0000000105aa6e98 CFRunLoopRunSpecific
+ 488
26  GraphicsServices                    0x0000000108cf1ad2 GSEventRunModal + 161
27  UIKit                               0x00000001045cc676 UIApplicationMain +
171
28  ios_web_inttests                    0x0000000100a36b72
_ZN4base18RunTestsFromIOSAppEv + 66
29  ios_web_inttests                    0x0000000100a32c2f
_ZN4base9TestSuite3RunEv + 31
30  ios_web_inttests                    0x00000001006aab05
_ZN4base8internal13FunctorTraitsIMNS_9TestSuiteEFivEvE6InvokeIPN3web12WebTestSuiteEJEEEiS4_OT_DpOT0_
+ 133
31  ios_web_inttests                    0x00000001006aaa24
_ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMNS_9TestSuiteEFivEJPN3web12WebTestSuiteEEEEiOT_DpOT0_
+ 68
32  ios_web_inttests                    0x00000001006aa9cd
_ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN3web12WebTestSuiteEEEEEEFivEE7RunImplIRKS5_RKNSt3__15tupleIJS9_EEEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
+ 77
33  ios_web_inttests                    0x00000001006aa8ec
_ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN3web12WebTestSuiteEEEEEEFivEE3RunEPNS0_13BindStateBaseE
+ 44
34  ios_web_inttests                    0x00000001015146db
_ZNK4base8internal8RunMixinINS_8CallbackIFivELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEE3RunEv
+ 59
35  ios_web_inttests                    0x0000000100a38df4
_ZN4base15LaunchUnitTestsEiPPcRKNS_8CallbackIFivELNS_8internal8CopyModeE1ELNS4_10RepeatModeE1EEE
+ 996
36  ios_web_inttests                    0x00000001006aa668 main + 168
37  libdyld.dylib                       0x000000010b1f192d start + 1

[yzshen1, 2016-12-16 16:57:35]

Thanks rohitrao@. Looking... If I cannot fix it quickly I will revert.