Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2581223002: Mojo JS bindings: change arrow operator in bindings.js to the old style. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: change arrow operator in bindings.js to the old style. The arrow operator is not supported on some old IOS versions. BUG=674807 Committed: https://crrev.com/a6a24645d969f861dd1b6ed319e52a42bb670e6c Cr-Commit-Position: refs/heads/master@{#439143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/public/js/bindings.js View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, Eugene. Would you please take a look? Btw, is there a way for me ...
4 years ago (2016-12-16 17:19:18 UTC) #4
Eugene But (OOO till 7-30)
lgtm!
4 years ago (2016-12-16 17:21:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581223002/1
4 years ago (2016-12-16 17:28:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 17:51:43 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 17:55:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6a24645d969f861dd1b6ed319e52a42bb670e6c
Cr-Commit-Position: refs/heads/master@{#439143}

Powered by Google App Engine
This is Rietveld 408576698