Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2577963006: Revert of Converts chrome to aura-mus (Closed)

Created:
4 years ago by Kunihiko Sakamoto
Modified:
4 years ago
Reviewers:
reveman, sadrul, sky
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, kalyank, Matt Giuca, rjkroege, sadrul, sdefresne+watchlist_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Converts chrome to aura-mus (patchset #4 id:60001 of https://codereview.chromium.org/2578893003/ ) Reason for revert: Broke Linux ChromiumOS Builder (dbg) build. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81640 Original issue's description: > Converts chrome to aura-mus > > aura-mus has a different environment than mus, so WMHelperMus (in exo) > was updated accordingly. > > This breaks switches::kUseMusInRenderer. I'll fix that next. > > BUG=672932 663525 > TEST=covered by tests > R=reveman@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381 > Cr-Commit-Position: refs/heads/master@{#439044} TBR=reveman@chromium.org,sadrul@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672932 663525 Committed: https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c Cr-Commit-Position: refs/heads/master@{#439063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -334 lines) Patch
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/settings_window_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/settings_window_observer.cc View 3 chunks +37 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 2 chunks +35 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_context_mus.h View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_context_mus.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_mus.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/exo/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/exo/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wm_helper_mus.h View 3 chunks +7 lines, -25 lines 0 comments Download
M components/exo/wm_helper_mus.cc View 3 chunks +64 lines, -61 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +7 lines, -29 lines 0 comments Download
M ui/aura/mus/focus_synchronizer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/aura/mus/focus_synchronizer.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/mus/mus_client.h View 4 chunks +8 lines, -14 lines 0 comments Download
M ui/views/mus/mus_client.cc View 2 chunks +37 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Kunihiko Sakamoto
Created Revert of Converts chrome to aura-mus
4 years ago (2016-12-16 07:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577963006/1
4 years ago (2016-12-16 08:00:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 08:01:31 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 08:05:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c
Cr-Commit-Position: refs/heads/master@{#439063}

Powered by Google App Engine
This is Rietveld 408576698