Add optional debugging output of what paint chunks go into what layers.

Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5aa24fc6891c693c3c7f8ceee14e7cb1a0c24ef2
Cr-Commit-Position: refs/heads/master@{#439151}

[chrishtr, 2016-12-15 17:52:17]

Description was changed from

==========
none


none


none


none

BUG=
==========

to

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-15 18:57:09]

Description was changed from

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-15 21:19:30]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2016-12-15 21:19:34]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 21:20:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-15 21:26:19]

https://codereview.chromium.org/2577123002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/invalidation/margin-expected.txt
(right):

https://codereview.chromium.org/2577123002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/margin-expected.txt:13:
"clientDebugName": "clientDebugName: \"LayoutView #document\"",
This is just an example, probably best to revert it before committing.

[wkorman, 2016-12-15 21:36:05]

lgtm

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/invalidation/margin.html (right):

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/margin.html:5:
window.layerTreeAsTextAdditionalFlags =
window.internals.LAYER_TREE_INCLUDES_DEBUG_INFO;
What is decision process re: when to include this in a LayoutTest? Is it for
tests we write now, to validate new compositing logic? Would this eventually
become a default-on? Perhaps worth documenting somewhere in code added in this
change.

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/margin.html:6:
window.internals.startStoringCompositedLayerDebugInfo(document);
Do we need to add something to reset-state between tests, to keep this from
persisting across reuse of the content shells? Like in
{Internals,InternalSettings}::resetToConsistentState.

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
(right):

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h:53:
// if LayerTreeIncludesDebugInfo is specified.
This read to me as if the debug info will only be stored if storeDebugInfo is
true *and* the LayerTreeIncludesDebugInfo flag is specified. Add parens around
the second part, or could just stay "...detailed debugging info in the layers
for use by layersAsJSON as needed."

[chrishtr, 2016-12-15 22:35:11]

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/invalidation/margin.html (right):

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/margin.html:5:
window.layerTreeAsTextAdditionalFlags =
window.internals.LAYER_TREE_INCLUDES_DEBUG_INFO;
On 2016/12/15 at 21:36:05, wkorman wrote:
> What is decision process re: when to include this in a LayoutTest? Is it for
tests we write now, to validate new compositing logic? Would this eventually
become a default-on? Perhaps worth documenting somewhere in code added in this
change.

I'm thinking it should be used for all tests which verify detailed compositing
triggers. I'm not totally sure yet though, want to see what works
best when converting tests.

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/margin.html:6:
window.internals.startStoringCompositedLayerDebugInfo(document);
On 2016/12/15 at 21:36:05, wkorman wrote:
> Do we need to add something to reset-state between tests, to keep this from
persisting across reuse of the content shells? Like in
{Internals,InternalSettings}::resetToConsistentState.

It's set on a FrameView, which is an object that only lives as long as its
containing webpage frame. So it will get reset "automatically".

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
(right):

https://codereview.chromium.org/2577123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h:53:
// if LayerTreeIncludesDebugInfo is specified.
On 2016/12/15 at 21:36:05, wkorman wrote:
> This read to me as if the debug info will only be stored if storeDebugInfo is
true *and* the LayerTreeIncludesDebugInfo flag is specified. Add parens around
the second part, or could just stay "...detailed debugging info in the layers
for use by layersAsJSON as needed."

Done.

[chrishtr, 2016-12-15 22:36:15]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-15 22:36:15]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2577123002/#ps80001
(title: "none")

[commit-bot: I haz the power, 2016-12-15 22:37:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 00:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:34:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-12-16 02:53:58]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-16 02:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2577123002/#ps100001
(title: "none")

[commit-bot: I haz the power, 2016-12-16 02:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:56:38]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[chrishtr, 2016-12-16 18:08:47]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:09:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 18:20:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481911727452700,
"parent_rev": "df160719a87feb5f16b6a113badf4febe0432cf9", "commit_rev":
"294a60a60e1e0c7d8cb05298e45f89e3c303aa6d"}

[commit-bot: I haz the power, 2016-12-16 18:20:32]

Description was changed from

==========
Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2577123002
==========

[commit-bot: I haz the power, 2016-12-16 18:20:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-16 18:22:42]

Description was changed from

==========
Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2577123002
==========

to

==========
Add optional debugging output of what paint chunks go into what layers.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/5aa24fc6891c693c3c7f8ceee14e7cb1a0c24ef2
Cr-Commit-Position: refs/heads/master@{#439151}
==========

[commit-bot: I haz the power, 2016-12-16 18:22:43]

Patchset 6 (id:??) landed as
https://crrev.com/5aa24fc6891c693c3c7f8ceee14e7cb1a0c24ef2
Cr-Commit-Position: refs/heads/master@{#439151}