third_party/WebKit/LayoutTests/paint/invalidation/margin.html - Issue 2577123002: Add optional debugging output of what paint chunks go into what layers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/margin.html

Issue 2577123002: Add optional debugging output of what paint chunks go into what layers. (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/invalidation/margin-expected.txt » ('j') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="resources/text-based-repaint.js"></script>	2 <script src="resources/text-based-repaint.js"></script>

3 <script>	3 <script>

	4 if (window.internals) {

	5 window.layerTreeAsTextAdditionalFlags = window.internals.LAYER_TREE_INCLUDES _DEBUG_INFO;
	wkorman 2016/12/15 21:36:05 What is decision process re: when to include this What is decision process re: when to include this in a LayoutTest? Is it for tests we write now, to validate new compositing logic? Would this eventually become a default-on? Perhaps worth documenting somewhere in code added in this change. chrishtr 2016/12/15 22:35:11 I'm thinking it should be used for all tests which Show quoted text On 2016/12/15 at 21:36:05, wkorman wrote: > What is decision process re: when to include this in a LayoutTest? Is it for tests we write now, to validate new compositing logic? Would this eventually become a default-on? Perhaps worth documenting somewhere in code added in this change. I'm thinking it should be used for all tests which verify detailed compositing triggers. I'm not totally sure yet though, want to see what works best when converting tests.
	6 window.internals.startStoringCompositedLayerDebugInfo(document);
	wkorman 2016/12/15 21:36:05 Do we need to add something to reset-state between Do we need to add something to reset-state between tests, to keep this from persisting across reuse of the content shells? Like in {Internals,InternalSettings}::resetToConsistentState. chrishtr 2016/12/15 22:35:11 It's set on a FrameView, which is an object that o Show quoted text On 2016/12/15 at 21:36:05, wkorman wrote: > Do we need to add something to reset-state between tests, to keep this from persisting across reuse of the content shells? Like in {Internals,InternalSettings}::resetToConsistentState. It's set on a FrameView, which is an object that only lives as long as its containing webpage frame. So it will get reset "automatically".
	7 }

4 function repaintTest()	8 function repaintTest()

5 {	9 {

6 // Margin change will visually move the content of the div.	10 // Margin change will visually move the content of the div.

7 // Should repaint the old position and the new position.	11 // Should repaint the old position and the new position.

8 document.getElementById('target').style.margin = '20px';	12 document.getElementById('target').style.margin = '20px';

9 }	13 }

10 window.onload = runRepaintAndPixelTest;	14 window.onload = runRepaintAndPixelTest;

11 </script>	15 </script>

12 <style>	16 <style>

13 body {	17 body {

14 margin: 0;	18 margin: 0;

15 }	19 }

16 div {	20 div {

17 width: 100px;	21 width: 100px;

18 height: 100px;	22 height: 100px;

19 position: absolute;	23 position: absolute;

20 background-color: green;	24 background-color: green;

21 }	25 }

22 </style>	26 </style>

23 <div id="target"></div>	27 <div id="target"></div>

OLD	NEW