Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 2577023003: Removes WebContentsViewMus/RenderWidgetHostViewMus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sadrul, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes WebContentsViewMus/RenderWidgetHostViewMus I updated the aura-mus classes to support mus. BUG=674575 TEST=none R=ben@chromium.org, sadrul@chromium.org Committed: https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a Cr-Commit-Position: refs/heads/master@{#439344}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 6

Patch Set 3 : feedback #

Patch Set 4 : merge #

Patch Set 5 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -1051 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
A content/browser/renderer_host/delegated_frame_host_client_aura.h View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/renderer_host/delegated_frame_host_client_aura.cc View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 8 chunks +11 lines, -19 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 31 chunks +124 lines, -138 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 7 chunks +74 lines, -23 lines 0 comments Download
D content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -137 lines 0 comments Download
D content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 2 chunks +6 lines, -21 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D content/browser/web_contents/web_contents_view_mus.h View 1 chunk +0 lines, -122 lines 0 comments Download
D content/browser/web_contents/web_contents_view_mus.cc View 1 chunk +0 lines, -270 lines 0 comments Download
M mash/package/mash_packaged_service.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
sky
4 years ago (2016-12-15 23:31:47 UTC) #1
sadrul
Nice! lgtm (I am still reviewing the first one) https://codereview.chromium.org/2577023003/diff/20001/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/2577023003/diff/20001/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode373 content/browser/renderer_host/render_widget_host_view_aura.cc:373: ...
4 years ago (2016-12-16 01:56:20 UTC) #2
sky
https://codereview.chromium.org/2577023003/diff/20001/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/2577023003/diff/20001/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode373 content/browser/renderer_host/render_widget_host_view_aura.cc:373: DelegatedFrameHostClientImpl( On 2016/12/16 01:56:20, sadrul wrote: > explicit Done. ...
4 years ago (2016-12-16 22:30:52 UTC) #3
Ben Goodger (Google)
lgtm
4 years ago (2016-12-16 22:42:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577023003/60001
4 years ago (2016-12-16 22:45:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/281494) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-16 23:15:48 UTC) #12
sky
I had to move the DelegatedFrameHostClient into its own header because a test was subclassing ...
4 years ago (2016-12-17 02:43:27 UTC) #17
Ben Goodger (Google)
lgtm
4 years ago (2016-12-17 04:51:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577023003/80001
4 years ago (2016-12-17 16:52:38 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-17 17:23:53 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-17 17:26:26 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/52a39e34c68e7e37138c666eccdd836a1162415a
Cr-Commit-Position: refs/heads/master@{#439344}

Powered by Google App Engine
This is Rietveld 408576698