Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2577023003: Removes WebContentsViewMus/RenderWidgetHostViewMus (Closed)
Patch Set: fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 3fb3a3d1fcbaa155e2e740913f1ef7f0374de06d..6b880fadd32008ee2935fb01990215f6d21e67a8 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -25,9 +25,9 @@
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/compositor/image_transport_factory.h"
#include "content/browser/compositor/owned_mailbox.h"
-#include "content/browser/renderer_host/delegated_frame_host.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/renderer_host/render_widget_host_view_event_handler.h"
+#include "content/browser/renderer_host/resize_lock.h"
#include "content/browser/renderer_host/text_input_manager.h"
#include "content/common/content_export.h"
#include "content/common/cursors/webcursor.h"
@@ -43,6 +43,7 @@
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/selection_bound.h"
#include "ui/wm/public/activation_delegate.h"
+#include "ui/wm/public/window_types.h"
namespace aura {
namespace client {
@@ -69,6 +70,8 @@ namespace content {
class LegacyRenderWidgetHostHWND;
#endif
+class DelegatedFrameHost;
+class DelegatedFrameHostClient;
class RenderFrameHostImpl;
class RenderWidgetHostImpl;
class RenderWidgetHostView;
@@ -79,7 +82,6 @@ struct TextInputState;
class CONTENT_EXPORT RenderWidgetHostViewAura
: public RenderWidgetHostViewBase,
NON_EXPORTED_BASE(public RenderWidgetHostViewEventHandler::Delegate),
- public DelegatedFrameHostClient,
public TextInputManager::Observer,
public ui::TextInputClient,
public display::DisplayObserver,
@@ -331,7 +333,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
}
private:
+ friend class DelegatedFrameHostClientAura;
friend class InputMethodAuraTestBase;
+ friend class RenderWidgetHostViewAuraTest;
friend class RenderWidgetHostViewAuraCopyRequestTest;
friend class TestInputMethodObserver;
FRIEND_TEST_ALL_PREFIXES(InputMethodResultAuraTest,
@@ -371,7 +375,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
class WindowAncestorObserver;
friend class WindowAncestorObserver;
- void CreateAuraWindow();
+ void CreateAuraWindow(ui::wm::WindowType type);
+
+ void CreateDelegatedFrameHostClient();
void UpdateCursorIfOverSelf();
@@ -412,22 +418,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// Called prior to removing |window_| from a WindowEventDispatcher.
void RemovingFromRootWindow();
- // DelegatedFrameHostClient implementation.
- ui::Layer* DelegatedFrameHostGetLayer() const override;
- bool DelegatedFrameHostIsVisible() const override;
- SkColor DelegatedFrameHostGetGutterColor(SkColor color) const override;
- gfx::Size DelegatedFrameHostDesiredSizeInDIP() const override;
- bool DelegatedFrameCanCreateResizeLock() const override;
- std::unique_ptr<ResizeLock> DelegatedFrameHostCreateResizeLock(
- bool defer_compositor_lock) override;
- void DelegatedFrameHostResizeLockWasReleased() override;
- void DelegatedFrameHostSendReclaimCompositorResources(
- int compositor_frame_sink_id,
- bool is_swap_ack,
- const cc::ReturnedResourceArray& resources) override;
- void SetBeginFrameSource(cc::BeginFrameSource* source) override;
- bool IsAutoResizeEnabled() const override;
-
// TextInputManager::Observer implementation.
void OnUpdateTextInputStateCalled(TextInputManager* text_input_manager,
RenderWidgetHostViewBase* updated_view,
@@ -486,6 +476,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
aura::Window* window_;
+ std::unique_ptr<DelegatedFrameHostClient> delegated_frame_host_client_;
+ // NOTE: this may be null.
std::unique_ptr<DelegatedFrameHost> delegated_frame_host_;
std::unique_ptr<WindowObserver> window_observer_;

Powered by Google App Engine
This is Rietveld 408576698