ui/aura/mus/window_tree_client.cc - Issue 2577023003: Removes WebContentsViewMus/RenderWidgetHostViewMus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2577023003: Removes WebContentsViewMus/RenderWidgetHostViewMus (Closed)

Patch Set: fix test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/mus/window_tree_client.cc

diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc

index 6f6c35090eac6685e39216ac8f3fa86a5eb27309..10a25a3a5f241c711602d5fb4d7c58674d261782 100644

--- a/ui/aura/mus/window_tree_client.cc

+++ b/ui/aura/mus/window_tree_client.cc

@@ -264,6 +264,9 @@ void WindowTreeClient::Embed(

uint32_t flags,

const ui::mojom::WindowTree::EmbedCallback& callback) {

DCHECK(tree_);

+ // Window::Init() must be called before Embed() (otherwise the server hasn't

+ // been told about the window).

+ DCHECK(window->layer());

if (!window->children().empty()) {

// The window server removes all children before embedding. In other words,

// it's generally an error to Embed() with existing children. So, fail

« no previous file with comments | « mash/package/mash_packaged_service.cc ('k') | no next file » | no next file with comments »