[turbofan] Combine family of TailCallRuntime() methods into single implementation.

[turbofan] Combine family of TailCallRuntime() methods into single implementation.

.. by using variadic templates in CodeAssembler.

BUG=

Review-Url: https://codereview.chromium.org/2577013003
Cr-Commit-Position: refs/heads/master@{#41746}
Committed: https://chromium.googlesource.com/v8/v8/+/4bd0cbdd5f9fe7fab8ddd4f39e1a14ba206d5248

[Igor Sheludko, 2016-12-15 17:00:56]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 17:01:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-15 17:01:16]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2016-12-15 17:01:17]

PTAL

[commit-bot: I haz the power, 2016-12-15 17:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:26:35]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-15 22:38:32]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-12-15 22:38:40]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-12-15 22:41:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:42:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-15 23:00:55]

Description was changed from

==========
[turbofan] Combine family of TailCallRuntime() methods into single
imeplementation.

.. by using variadic templates in CodeAssembler and RawMachineAssembler.

BUG=
==========

to

==========
[turbofan] Combine family of TailCallRuntime() methods into single
implementation.

.. by using variadic templates in CodeAssembler.

BUG=
==========

[commit-bot: I haz the power, 2016-12-15 23:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:09:32]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-15 23:34:07]

https://codereview.chromium.org/2577013003/diff/40001/src/compiler/raw-machin...
File src/compiler/raw-machine-assembler.h (right):

https://codereview.chromium.org/2577013003/diff/40001/src/compiler/raw-machin...
src/compiler/raw-machine-assembler.h:711: Node* CallV(CallDescriptor* desc,
Node* target, TArgs... args) {
I added suffix V to avoid conflicts in tests with CallHelper<R>::Call() methods.

[Igor Sheludko, 2016-12-16 07:50:41]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 07:50:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 08:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 08:24:40]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-16 09:08:09]

LGTM. Nice. Just nits.

https://codereview.chromium.org/2577013003/diff/60001/src/compiler/raw-machin...
File src/compiler/raw-machine-assembler.h (left):

https://codereview.chromium.org/2577013003/diff/60001/src/compiler/raw-machin...
src/compiler/raw-machine-assembler.h:9: #include "src/code-factory.h"
Nice! I like that the implementations moved to the CC-file.

https://codereview.chromium.org/2577013003/diff/60001/src/compiler/raw-machin...
File src/compiler/raw-machine-assembler.h (right):

https://codereview.chromium.org/2577013003/diff/60001/src/compiler/raw-machin...
src/compiler/raw-machine-assembler.h:709: // Call a given call descriptor and
the given arguments.
nit: Please add a sentence to the comment saying that "the call target is passed
as part of the {inputs} array".

https://codereview.chromium.org/2577013003/diff/60001/src/compiler/raw-machin...
src/compiler/raw-machine-assembler.h:712: // Tail call a given call descriptor
and the given arguments.
nit: Likewise.

[Igor Sheludko, 2016-12-16 09:31:16]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-12-16 09:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2577013003/#ps80001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-12-16 09:31:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 09:58:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481880676494940,
"parent_rev": "e3ad4f131b9453252f77f20046427959acf8d939", "commit_rev":
"4bd0cbdd5f9fe7fab8ddd4f39e1a14ba206d5248"}

[commit-bot: I haz the power, 2016-12-16 09:58:59]

Description was changed from

==========
[turbofan] Combine family of TailCallRuntime() methods into single
implementation.

.. by using variadic templates in CodeAssembler.

BUG=
==========

to

==========
[turbofan] Combine family of TailCallRuntime() methods into single
implementation.

.. by using variadic templates in CodeAssembler.

BUG=

Review-Url: https://codereview.chromium.org/2577013003
Cr-Commit-Position: refs/heads/master@{#41746}
Committed:
https://chromium.googlesource.com/v8/v8/+/4bd0cbdd5f9fe7fab8ddd4f39e1a14ba206...
==========

[commit-bot: I haz the power, 2016-12-16 09:59:00]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/4bd0cbdd5f9fe7fab8ddd4f39e1a14ba206...