Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2580823002: [turbofan] Combine family of CallRuntime() methods into single imeplementation. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
3 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Combine family of CallRuntime() methods into single imeplementation. .. by using variadic templates in CodeAssembler and RawMachineAssembler. BUG= Review-Url: https://codereview.chromium.org/2580823002 Cr-Commit-Position: refs/heads/master@{#41733} Committed: https://chromium.googlesource.com/v8/v8/+/c131dd9561de12eae93d3ac032414067c80f4819

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments and fixing Windows builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -167 lines) Patch
M src/code-factory.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +2 lines, -10 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 chunks +19 lines, -49 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +22 lines, -16 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -92 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (16 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-15 14:06:01 UTC) #5
Michael Starzinger
LGTM. https://codereview.chromium.org/2580823002/diff/20001/src/code-factory.h File src/code-factory.h (right): https://codereview.chromium.org/2580823002/diff/20001/src/code-factory.h#newcode33 src/code-factory.h:33: static Handle<Code> RuntimeCEntry(Isolate* isolate, int result_size = 1); ...
4 years ago (2016-12-15 14:39:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580823002/80001
4 years ago (2016-12-15 16:54:02 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 17:18:48 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/c131dd9561de12eae93d3ac032414067c80...

Powered by Google App Engine
This is Rietveld 408576698