[turbofan] Combine family of CallStub() methods into single implementation.

[turbofan] Combine family of CallStub() methods into single implementation.

.. by using variadic templates in CodeAssembler.

BUG=

Review-Url: https://codereview.chromium.org/2577913003
Cr-Commit-Position: refs/heads/master@{#41749}
Committed: https://chromium.googlesource.com/v8/v8/+/6eeab124143a0f98cbc72e7a8b721b1bf9c83978

[Igor Sheludko, 2016-12-16 09:21:06]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-12-16 09:23:28]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 09:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-16 09:34:56]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2016-12-16 09:34:56]

PTAL

[commit-bot: I haz the power, 2016-12-16 09:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 09:50:06]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-12-16 10:08:16]

LGTM.

https://codereview.chromium.org/2577913003/diff/20001/src/compiler/code-assem...
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2577913003/diff/20001/src/compiler/code-assem...
src/compiler/code-assembler.cc:504: int stack_parameter_count = argc -
descriptor.GetRegisterParameterCount();
It is really unfortunate that we cannot rely on
{CallInterfaceDescriptor::GetStackParameterCount} being accurate. Can we at
least add a "DCHECK_LE(descriptor.GetStackParameterCount(),
stack_parameter_count)" here?

[Igor Sheludko, 2016-12-16 10:15:06]

https://codereview.chromium.org/2577913003/diff/20001/src/compiler/code-assem...
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2577913003/diff/20001/src/compiler/code-assem...
src/compiler/code-assembler.cc:504: int stack_parameter_count = argc -
descriptor.GetRegisterParameterCount();
On 2016/12/16 10:08:15, Michael Starzinger wrote:
> It is really unfortunate that we cannot rely on
> {CallInterfaceDescriptor::GetStackParameterCount} being accurate. Can we at
> least add a "DCHECK_LE(descriptor.GetStackParameterCount(),
> stack_parameter_count)" here?

Done.

[Igor Sheludko, 2016-12-16 10:15:20]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-12-16 10:15:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2577913003/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-12-16 10:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:40:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481883320868650,
"parent_rev": "c5ea51259c488572277eced46c4c0149ffe96b56", "commit_rev":
"6eeab124143a0f98cbc72e7a8b721b1bf9c83978"}

[commit-bot: I haz the power, 2016-12-16 10:40:22]

Description was changed from

==========
[turbofan] Combine family of CallStub() methods into single implementation.

.. by using variadic templates in CodeAssembler.

BUG=
==========

to

==========
[turbofan] Combine family of CallStub() methods into single implementation.

.. by using variadic templates in CodeAssembler.

BUG=

Review-Url: https://codereview.chromium.org/2577913003
Cr-Commit-Position: refs/heads/master@{#41749}
Committed:
https://chromium.googlesource.com/v8/v8/+/6eeab124143a0f98cbc72e7a8b721b1bf9c...
==========

[commit-bot: I haz the power, 2016-12-16 10:40:23]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6eeab124143a0f98cbc72e7a8b721b1bf9c...