[DevTools] Migrate input domain to new generator.

[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/111fdd030ce49ce1de525ac10a983bed8fd8720e
Cr-Commit-Position: refs/heads/master@{#439360}

[dgozman, 2016-12-14 06:53:29]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-14 06:53:29]

Could you please take a look?

[caseq, 2016-12-14 18:18:18]

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:648:
browser_domains_list = []
why not nuke these altogether?

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/input_handler.cc (right):

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:41: } else if (in.fromJust()
== Input::GestureSourceTypeEnum::Default) {
no else after return

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:44: } else if (in.fromJust()
== Input::GestureSourceTypeEnum::Touch) {
ditto.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:47: } else if (in.fromJust()
== Input::GestureSourceTypeEnum::Mouse) {
ditto.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:50: } else {
ditto.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:140: if (send_success)
So success we try to send only once...

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:143:
callback->sendFailure(Response::Error(
... and failure may be sent more than once?

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:497:
std::move(gesture_source_type),
weird indent.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:512:
base::Passed(std::move(callback)), is_last_tap));
This will not have the result you expect. Do we have this covered by a test btw?

[dgozman, 2016-12-15 04:20:08]

Tested manually synthesizeXXX methods - they work.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:648:
browser_domains_list = []
On 2016/12/14 18:18:18, caseq wrote:
> why not nuke these altogether?

Next patch :-)

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/input_handler.cc (right):

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:41: } else if (in.fromJust()
== Input::GestureSourceTypeEnum::Default) {
On 2016/12/14 18:18:18, caseq wrote:
> no else after return

Done.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:497:
std::move(gesture_source_type),
On 2016/12/14 18:18:18, caseq wrote:
> weird indent.

Done.

https://codereview.chromium.org/2575513004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.cc:512:
base::Passed(std::move(callback)), is_last_tap));
On 2016/12/14 18:18:18, caseq wrote:
> This will not have the result you expect. Do we have this covered by a test
btw?

I guess the only tests we have for this are telemetry. Fixed.

[dgozman, 2016-12-15 07:10:06]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 07:10:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 08:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 08:22:29]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-12-16 18:08:35]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 19:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:59:50]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[caseq, 2016-12-16 20:39:46]

lgtm

[dgozman, 2016-12-16 21:41:12]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-16 21:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 21:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 21:55:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-12-17 20:49:18]

Description was changed from

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
==========

to

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-17 20:52:09]

TBR'ing pfeldman for BUILD.gn

[dgozman, 2016-12-17 21:01:55]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-17 21:02:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 22:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 22:05:45]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-12-17 23:33:11]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 23:33:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 00:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 00:19:37]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-18 00:45:16]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-18 00:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 00:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482021916656080,
"parent_rev": "e0c7f6b59e2b751a30d16077dd11de715e0d6ce5", "commit_rev":
"353c90afbc934d43dee90327a099556728b6926e"}

[commit-bot: I haz the power, 2016-12-18 00:50:04]

Description was changed from

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2575513004
==========

[commit-bot: I haz the power, 2016-12-18 00:50:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-18 00:52:16]

Description was changed from

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2575513004
==========

to

==========
[DevTools] Migrate input domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/111fdd030ce49ce1de525ac10a983bed8fd8720e
Cr-Commit-Position: refs/heads/master@{#439360}
==========

[commit-bot: I haz the power, 2016-12-18 00:52:17]

Patchset 2 (id:??) landed as
https://crrev.com/111fdd030ce49ce1de525ac10a983bed8fd8720e
Cr-Commit-Position: refs/heads/master@{#439360}