[DevTools] Migrate target domain to new generator.

[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
Cr-Commit-Position: refs/heads/master@{#438733}

[dgozman, 2016-12-14 05:51:43]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-14 05:51:43]

Could you please take a look?

[caseq, 2016-12-14 06:44:07]

lgtm

https://codereview.chromium.org/2574843003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/target_handler.cc (right):

https://codereview.chromium.org/2574843003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/target_handler.cc:291: return
Response::Error("No target with given id found");
This should perhaps be consistent with CloseTarget(), i.e. also use
InvalidParam().

https://codereview.chromium.org/2574843003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/target_handler.cc:299: return
Response::Error("Not attached to the target");
ditto.

[dgozman, 2016-12-15 03:16:35]

https://codereview.chromium.org/2574843003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/target_handler.cc (right):

https://codereview.chromium.org/2574843003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/target_handler.cc:291: return
Response::Error("No target with given id found");
On 2016/12/14 06:44:06, caseq wrote:
> This should perhaps be consistent with CloseTarget(), i.e. also use
> InvalidParam().

Done.

[dgozman, 2016-12-15 03:17:05]

Description was changed from

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
==========

to

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-15 03:17:17]

TBR'ing pfeldman for BUILD.gn

[dgozman, 2016-12-15 03:17:19]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-15 03:17:20]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2574843003/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-12-15 03:17:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:18:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481771839878890,
"parent_rev": "4e3db0e583c64709d77793a24e6e209483814d12", "commit_rev":
"144f88b2aef6f136d94688c3fdde301352c39d88"}

[commit-bot: I haz the power, 2016-12-15 04:19:32]

Description was changed from

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2574843003
==========

[commit-bot: I haz the power, 2016-12-15 04:19:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 04:23:59]

Description was changed from

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2574843003
==========

to

==========
[DevTools] Migrate target domain to new generator.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
Cr-Commit-Position: refs/heads/master@{#438733}
==========

[commit-bot: I haz the power, 2016-12-15 04:24:00]

Patchset 2 (id:??) landed as
https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
Cr-Commit-Position: refs/heads/master@{#438733}

[dgozman, 2016-12-15 22:31:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2578303002/ by dgozman@chromium.org.

The reason for reverting is: Speculative.