Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2573423002: [DevTools] Remove old generator in content. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove old generator in content. BUG=664683 TBR=pfeldman Committed: https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0 Cr-Commit-Position: refs/heads/master@{#439377}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1352 lines) Patch
M content/browser/BUILD.gn View 1 4 chunks +0 lines, -10 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 3 chunks +1 line, -8 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 3 chunks +5 lines, -13 lines 0 comments Download
D content/browser/devtools/devtools_protocol_handler.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/devtools/devtools_protocol_handler.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_client.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_client.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_delegate.h View 1 chunk +0 lines, -22 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -818 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-15 07:09:57 UTC) #2
caseq
lgtm https://codereview.chromium.org/2573423002/diff/1/content/browser/devtools/devtools_agent_host_impl.cc File content/browser/devtools/devtools_agent_host_impl.cc (right): https://codereview.chromium.org/2573423002/diff/1/content/browser/devtools/devtools_agent_host_impl.cc#newcode62 content/browser/devtools/devtools_agent_host_impl.cc:62: base::StringToInt(tokens[0], &major) && major == 1 && StringToUInt() ...
4 years ago (2016-12-16 00:10:28 UTC) #3
dgozman
https://codereview.chromium.org/2573423002/diff/1/content/browser/devtools/devtools_agent_host_impl.cc File content/browser/devtools/devtools_agent_host_impl.cc (right): https://codereview.chromium.org/2573423002/diff/1/content/browser/devtools/devtools_agent_host_impl.cc#newcode62 content/browser/devtools/devtools_agent_host_impl.cc:62: base::StringToInt(tokens[0], &major) && major == 1 && On 2016/12/16 ...
4 years ago (2016-12-18 16:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573423002/20001
4 years ago (2016-12-18 18:48:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/328603)
4 years ago (2016-12-18 18:54:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573423002/20001
4 years ago (2016-12-18 20:40:33 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-18 20:44:28 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-18 20:46:59 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0
Cr-Commit-Position: refs/heads/master@{#439377}

Powered by Google App Engine
This is Rietveld 408576698