Store data reduction proxy server in a separate class

Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435, 671810, 675769
Committed: https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02
Cr-Commit-Position: refs/heads/master@{#439670}

[tbansal1, 2016-12-15 02:56:31]

Description was changed from

==========
Store data reduction proxy server properties

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

to

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

[tbansal1, 2016-12-15 02:57:41]

Description was changed from

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

to

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

The properties are set only if client config service is in use. 
Properties are not set when the proxies are set using command line
or if the proxies are hard-coded (using d_r_p_params).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

[tbansal1, 2016-12-15 02:57:48]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 02:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 03:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 03:03:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tbansal1, 2016-12-15 07:18:33]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 07:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 07:23:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[tbansal1, 2016-12-15 07:48:33]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 07:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-15 07:54:26]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-12-15 07:54:53]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-15 07:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 07:56:37]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tbansal1, 2016-12-15 17:43:22]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 17:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:44:53]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-15 19:33:02]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2016-12-15 20:45:29]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 20:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-15 20:48:59]

Description was changed from

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

The properties are set only if client config service is in use. 
Properties are not set when the proxies are set using command line
or if the proxies are hard-coded (using d_r_p_params).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

to

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

The properties are set only if (i) client config service is in use; (ii) 
if proxies are hard-coded via d_r_p_params class. Properties are not set
when the proxies are overridden using command line.

When client config is in use, properties are computed from the client 
config sent by the client config server. When proxies are hard-coded,
the properties are also hard-coded.

The properties will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810
==========

[tbansal1, 2016-12-15 20:49:53]

tbansal@chromium.org changed reviewers:
+ jpfeiff@chromium.org, megjablon@chromium.org

[tbansal1, 2016-12-15 20:49:54]

jpfeiff: ptal at proto file

megjablon: ptal at *

Thanks.

[commit-bot: I haz the power, 2016-12-15 20:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 20:51:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tbansal1, 2016-12-15 20:57:11]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-12-15 20:57:26]

Patchset #2 (id:70001) has been deleted

[commit-bot: I haz the power, 2016-12-15 20:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 21:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:36:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbansal1, 2016-12-15 22:31:47]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-12-15 22:31:47]

ryansturm: ptal since you looked at the design docs. Thanks

[RyanSturm, 2016-12-15 23:21:42]

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc:23:
using net::HostPortPair;
remove these and fix the errors.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:441:
succeeded = ParseAndApplyProxyConfig(config);
This calls GetProxiesForHTTP() as well. Consider removing the other call to
GetProxiesForHTTP and store the values or add out params to
ParseAndApplyProxyConfig.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:426:
mutable_config->UpdateValues(proxy_servers_, properties_);
This will DCHECK since properties_ is going to be empty if you use
DataReductionProxyTestContext::Builder::WithProxiesForHttp

[jpfeiff, 2016-12-15 23:44:24]

lgtm

LGTM for proto changes.

[tbansal1, 2016-12-17 02:01:41]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-12-17 02:02:05]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-12-17 02:02:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 03:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 03:41:22]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-19 18:47:22]

Description was changed from

==========
Store data reduction proxy server properties

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

The properties are set only if (i) client config service is in use; (ii) 
if proxies are hard-coded via d_r_p_params class. Properties are not set
when the proxies are overridden using command line.

When client config is in use, properties are computed from the client 
config sent by the client config server. When proxies are hard-coded,
the properties are also hard-coded.

The properties will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810
==========

to

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810
==========

[tbansal1, 2016-12-19 18:49:01]

tbansal@chromium.org changed reviewers:
- megjablon@chromium.org

[tbansal1, 2016-12-19 18:49:03]

ryansturm: ptal. Thanks.
Moving megjablon@ to cc' as part of cleanup. Please feel free to leave comments
though.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc:23:
using net::HostPortPair;
On 2016/12/15 23:21:42, Ryan Sturm wrote:
> remove these and fix the errors.

Done.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:441:
succeeded = ParseAndApplyProxyConfig(config);
On 2016/12/15 23:21:42, Ryan Sturm wrote:
> This calls GetProxiesForHTTP() as well. Consider removing the other call to
> GetProxiesForHTTP and store the values or add out params to
> ParseAndApplyProxyConfig.

Obsolete.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:426:
mutable_config->UpdateValues(proxy_servers_, properties_);
On 2016/12/15 23:21:42, Ryan Sturm wrote:
> This will DCHECK since properties_ is going to be empty if you use
> DataReductionProxyTestContext::Builder::WithProxiesForHttp

Obsolete.

[RyanSturm, 2016-12-19 21:15:19]

I'm still looking at tests, but I will likely find no more comments.

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc:23:
using net::HostPortPair;
On 2016/12/19 18:49:03, tbansal1 wrote:
> On 2016/12/15 23:21:42, Ryan Sturm wrote:
> > remove these and fix the errors.
> 
> Done.

Thanks!

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2575323002/diff/90001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:441:
succeeded = ParseAndApplyProxyConfig(config);
On 2016/12/19 18:49:03, tbansal1 wrote:
> On 2016/12/15 23:21:42, Ryan Sturm wrote:
> > This calls GetProxiesForHTTP() as well. Consider removing the other call to
> > GetProxiesForHTTP and store the values or add out params to
> > ParseAndApplyProxyConfig.
> 
> Obsolete.

This still parses the proto twice in a row. GetProxiesForHTTP is called in
ParseAndApplyProxyConfig and then called below.

I'd be happier if you could either return the vector from ParseAndApplyConfig or
if you could std::move the vector within ParseAndApplyProxyConfig to Config.

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
(right):

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:414:
DataReductionProxyServer::ConvertToNetProxyServers(
Can you open a bug to replace these calls with changing configurator_->Enabled
to accept the vector of the new type?

IMO, now that this type exists, we should transition to storing and using 
net::ProxyServer only when interfacing with net/.

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
File components/data_reduction_proxy/core/common/data_reduction_proxy_server.h
(right):

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:15: //
A class that stores a single data reduction proxy server.
nit maybe: s/stores/stores information about/

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:16:
class DataReductionProxyServer {
add a copy contructor/ copy assign and DISALLOW* if necessary

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:32:
ProxyServer_ProxyType proxy_type_;
I'm not sure a proto type is good or bad as a class member. I am actually okay
with it, but I wanted to double check that you didn't think there is an
over-exposing of proto types here.

[RyanSturm, 2016-12-19 21:24:46]

lgtm % previous comments

[tbansal1, 2016-12-19 23:18:10]

Description was changed from

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810
==========

to

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769
==========

[tbansal1, 2016-12-19 23:20:00]

Patchset #3 (id:130001) has been deleted

[tbansal1, 2016-12-19 23:21:36]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 23:22:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-19 23:23:47]

Patchset #3 (id:150001) has been deleted

[tbansal1, 2016-12-19 23:23:51]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-12-19 23:23:57]

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
(right):

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:414:
DataReductionProxyServer::ConvertToNetProxyServers(
On 2016/12/19 21:15:18, Ryan Sturm wrote:
> Can you open a bug to replace these calls with changing configurator_->Enabled
> to accept the vector of the new type?
> 
> IMO, now that this type exists, we should transition to storing and using 
> net::ProxyServer only when interfacing with net/.

crbug.com/675764

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
File components/data_reduction_proxy/core/common/data_reduction_proxy_server.h
(right):

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:15: //
A class that stores a single data reduction proxy server.
On 2016/12/19 21:15:18, Ryan Sturm wrote:
> nit maybe: s/stores/stores information about/
> 

Done.

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:16:
class DataReductionProxyServer {
On 2016/12/19 21:15:18, Ryan Sturm wrote:
> add a copy contructor/ copy assign and DISALLOW* if necessary

Done.

https://codereview.chromium.org/2575323002/diff/110001/components/data_reduct...
components/data_reduction_proxy/core/common/data_reduction_proxy_server.h:32:
ProxyServer_ProxyType proxy_type_;
On 2016/12/19 21:15:18, Ryan Sturm wrote:
> I'm not sure a proto type is good or bad as a class member. I am actually okay
> with it, but I wanted to double check that you didn't think there is an
> over-exposing of proto types here.

Done. Renamed proxy_type() to GetProxyTypeForTesting(). I do not think it
should be exposed. Instead, we should have methods in this class which
expose the properties. e.g., bool SupportsQuic(), bool SupportsVideo() etc.

[commit-bot: I haz the power, 2016-12-19 23:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:08:03]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-20 02:12:20]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-12-20 02:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jpfeiff@chromium.org, ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2575323002/#ps170001
(title: "ryansturm comments")

[commit-bot: I haz the power, 2016-12-20 02:12:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:17:41]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1482199940732720,
"parent_rev": "6132a92a61cb852659ffa9987fdd7bf2f356b8ce", "commit_rev":
"72437e0da8495152dc44f079c9a3b8be7539fd62"}

[commit-bot: I haz the power, 2016-12-20 02:18:17]

Description was changed from

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769
==========

to

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769

Review-Url: https://codereview.chromium.org/2575323002
==========

[commit-bot: I haz the power, 2016-12-20 02:18:20]

Committed patchset #3 (id:170001)

[commit-bot: I haz the power, 2016-12-20 02:21:40]

Description was changed from

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769

Review-Url: https://codereview.chromium.org/2575323002
==========

to

==========
Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769

Committed: https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02
Cr-Commit-Position: refs/heads/master@{#439670}
==========

[commit-bot: I haz the power, 2016-12-20 02:21:41]

Patchset 3 (id:??) landed as
https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02
Cr-Commit-Position: refs/heads/master@{#439670}