components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h - Issue 2575323002: Store data reduction proxy server in a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h

Issue 2575323002: Store data reduction proxy server in a separate class (Closed)

Patch Set: ryansturm comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h

index 33e1e718e1f83c9fa8a156ec791eee873f9d8362..55643234ff6f8ac2554a828830ac5180e02bda7e 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h

@@ -35,6 +35,8 @@ class DataReductionProxyConfigurator {

// Enables data reduction using the proxy servers in |proxies_for_http|.

// |secure_transport_restricted| indicates that proxies going over secure

// transports can not be used.

+ // TODO: crbug.com/675764: Pass a vector of DataReductionProxyServer

+ // instead of net::ProxyServer.

virtual void Enable(bool secure_transport_restricted,

const std::vector<net::ProxyServer>& proxies_for_http);