Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

Issue 2575323002: Store data reduction proxy server in a separate class (Closed)
Patch Set: ryansturm comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
index b51f915305b6ee384ba15fa738dd209ff4a53aa2..ee75daf341a6eb72ce08c7223bd9e9e099eb44e7 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
@@ -17,6 +17,7 @@
namespace data_reduction_proxy {
class DataReductionProxyParams;
+class DataReductionProxyServer;
// A |DataReductionProxyConfigValues| which is permitted to change its
// underlying values via the UpdateValues method.
@@ -33,7 +34,7 @@ class DataReductionProxyMutableConfigValues
// Updates |proxies_for_http_| with the provided values.
// Virtual for testing.
virtual void UpdateValues(
- const std::vector<net::ProxyServer>& proxies_for_http);
+ const std::vector<DataReductionProxyServer>& proxies_for_http);
// Invalidates |this| by clearing the stored Data Reduction Proxy servers.
void Invalidate();
@@ -43,7 +44,7 @@ class DataReductionProxyMutableConfigValues
bool holdback() const override;
bool allowed() const override;
bool fallback_allowed() const override;
- const std::vector<net::ProxyServer>& proxies_for_http() const override;
+ const std::vector<DataReductionProxyServer> proxies_for_http() const override;
const GURL& secure_proxy_check_url() const override;
protected:
@@ -54,13 +55,13 @@ class DataReductionProxyMutableConfigValues
bool holdback_;
bool allowed_;
bool fallback_allowed_;
- std::vector<net::ProxyServer> proxies_for_http_;
+ std::vector<DataReductionProxyServer> proxies_for_http_;
GURL secure_proxy_check_url_;
// Permits use of locally specified Data Reduction Proxy servers instead of
// ones specified from the Data Saver API.
bool use_override_proxies_for_http_;
- std::vector<net::ProxyServer> override_proxies_for_http_;
+ std::vector<DataReductionProxyServer> override_proxies_for_http_;
// Enforce usage on the IO thread.
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698