Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 2579923002: [DevTools] Call InnerDetach instead of NotifyDetached in DTAHI::HostClosed. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Call InnerDetach instead of NotifyDetached in DTAHI::HostClosed. InnerDetach destroyes the current session and domain handlers, as opposite to NotifyDetached, which prevents stale pointers and inconsistent state at the time of DTAHI destruction. BUG=674474 Committed: https://crrev.com/6ac97c212042cc7f4f3b7c3033c8ef4392a133ed Cr-Commit-Position: refs/heads/master@{#439003}

Patch Set 1 #

Patch Set 2 : on master #

Patch Set 3 : no deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/devtools/devtools_agent_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-15 23:24:15 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-16 00:19:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579923002/40001
4 years ago (2016-12-16 02:09:41 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-16 03:36:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 03:40:41 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ac97c212042cc7f4f3b7c3033c8ef4392a133ed
Cr-Commit-Position: refs/heads/master@{#439003}

Powered by Google App Engine
This is Rietveld 408576698