Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Committed: https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad
Cr-Commit-Position: refs/heads/master@{#438623}

[pilgrim_google, 2016-12-13 15:46:01]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2016-12-13 15:46:18]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2016-12-13 15:46:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 17:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:22:46]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-14 01:21:39]

LGTM

[pilgrim_google, 2016-12-14 02:43:55]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:44:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 02:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:57:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2016-12-14 15:34:07]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2016-12-14 15:34:08]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2574773002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-14 15:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:21:46]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pilgrim_google, 2016-12-14 16:27:16]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 17:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:09:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pilgrim_google, 2016-12-14 19:20:03]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:21:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:17:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481743203053800,
"parent_rev": "5faf1f1bb86b6efeea9f88842f5d293e2d3838cd", "commit_rev":
"36a345884fb997a8c0e15f497a782d1c3571d9f1"}

[commit-bot: I haz the power, 2016-12-14 21:17:31]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2574773002
==========

[commit-bot: I haz the power, 2016-12-14 21:17:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 21:19:45]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2574773002
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Committed: https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad
Cr-Commit-Position: refs/heads/master@{#438623}
==========

[commit-bot: I haz the power, 2016-12-14 21:19:46]

Patchset 2 (id:??) landed as
https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad
Cr-Commit-Position: refs/heads/master@{#438623}