Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ScriptRunner.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ScriptLoader.h"
 #include "platform/heap/Handle.h"
@@ skipping 69 matching lines @@
 
   m_platform.runUntilIdle();
 }
 
 TEST_F(ScriptRunnerTest, QueueMultipleScripts_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   HeapVector<Member<MockScriptLoader>> scriptLoaders;
-  scriptLoaders.append(scriptLoader1);
-  scriptLoaders.append(scriptLoader2);
-  scriptLoaders.append(scriptLoader3);
+  scriptLoaders.push_back(scriptLoader1);
+  scriptLoaders.push_back(scriptLoader2);
+  scriptLoaders.push_back(scriptLoader3);
 
   for (ScriptLoader* scriptLoader : scriptLoaders) {
     m_scriptRunner->queueScriptForExecution(scriptLoader,
                                             ScriptRunner::InOrder);
   }
 
   for (size_t i = 0; i < scriptLoaders.size(); ++i) {
     EXPECT_CALL(*scriptLoaders[i], execute()).WillOnce(Invoke([this, i] {
-      m_order.append(i + 1);
+      m_order.push_back(i + 1);
     }));
   }
 
   // Make the scripts become ready in reverse order.
   bool isReady[] = {false, false, false};
 
   for (size_t i = 0; i < scriptLoaders.size(); ++i) {
     EXPECT_CALL(*scriptLoaders[i], isReady())
         .WillRepeatedly(Invoke([&isReady, i] { return isReady[i]; }));
   }
@@ skipping 29 matching lines @@
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(false));
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(true));
   m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::InOrder);
 
   m_scriptRunner->notifyScriptReady(scriptLoader4, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader5, ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
-    m_order.append(1);
+    m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
-    m_order.append(2);
+    m_order.push_back(2);
   }));
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
-    m_order.append(3);
+    m_order.push_back(3);
   }));
   EXPECT_CALL(*scriptLoader4, execute()).WillOnce(Invoke([this] {
-    m_order.append(4);
+    m_order.push_back(4);
   }));
   EXPECT_CALL(*scriptLoader5, execute()).WillOnce(Invoke([this] {
-    m_order.append(5);
+    m_order.push_back(5);
   }));
 
   m_platform.runUntilIdle();
 
   // Async tasks are expected to run first.
   EXPECT_THAT(m_order, ElementsAre(4, 5, 1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_Async) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader3, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::Async);
 
   MockScriptLoader* scriptLoader = scriptLoader2;
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([scriptLoader, this] {
-    m_order.append(1);
+    m_order.push_back(1);
     m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::Async);
   }));
 
   scriptLoader = scriptLoader3;
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([scriptLoader, this] {
-    m_order.append(2);
+    m_order.push_back(2);
     m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::Async);
   }));
 
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
-    m_order.append(3);
+    m_order.push_back(3);
   }));
 
   // Make sure that re-entrant calls to notifyScriptReady don't cause
   // ScriptRunner::execute to do more work than expected.
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1));
 
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2));
 
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(true));
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::InOrder);
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::InOrder);
 
   MockScriptLoader* scriptLoader = scriptLoader2;
   EXPECT_CALL(*scriptLoader1, execute())
       .WillOnce(Invoke([scriptLoader, &scriptLoader2, this] {
-        m_order.append(1);
+        m_order.push_back(1);
         m_scriptRunner->queueScriptForExecution(scriptLoader,
                                                 ScriptRunner::InOrder);
         m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::InOrder);
       }));
 
   scriptLoader = scriptLoader3;
   EXPECT_CALL(*scriptLoader2, execute())
       .WillOnce(Invoke([scriptLoader, &scriptLoader3, this] {
-        m_order.append(2);
+        m_order.push_back(2);
         m_scriptRunner->queueScriptForExecution(scriptLoader,
                                                 ScriptRunner::InOrder);
         m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::InOrder);
       }));
 
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
-    m_order.append(3);
+    m_order.push_back(3);
   }));
 
   // Make sure that re-entrant calls to queueScriptForExecution don't cause
   // ScriptRunner::execute to do more work than expected.
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1));
 
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2));
 
   m_platform.runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_ManyAsyncScripts) {
   MockScriptLoader* scriptLoaders[20];
   for (int i = 0; i < 20; i++)
     scriptLoaders[i] = nullptr;
 
   for (int i = 0; i < 20; i++) {
     scriptLoaders[i] = MockScriptLoader::create(m_element.get());
     EXPECT_CALL(*scriptLoaders[i], isReady()).WillRepeatedly(Return(true));
 
     m_scriptRunner->queueScriptForExecution(scriptLoaders[i],
                                             ScriptRunner::Async);
 
     if (i > 0) {
       EXPECT_CALL(*scriptLoaders[i], execute()).WillOnce(Invoke([this, i] {
-        m_order.append(i);
+        m_order.push_back(i);
       }));
     }
   }
 
   m_scriptRunner->notifyScriptReady(scriptLoaders[0], ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoaders[1], ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoaders[0], execute())
       .WillOnce(Invoke([&scriptLoaders, this] {
         for (int i = 2; i < 20; i++)
           m_scriptRunner->notifyScriptReady(scriptLoaders[i],
                                             ScriptRunner::Async);
-        m_order.append(0);
+        m_order.push_back(0);
       }));
 
   m_platform.runUntilIdle();
 
   int expected[] = {0,  1,  2,  3,  4,  5,  6,  7,  8,  9,
                     10, 11, 12, 13, 14, 15, 16, 17, 18, 19};
 
   EXPECT_THAT(m_order, testing::ElementsAreArray(expected));
 }
 
 TEST_F(ScriptRunnerTest, ResumeAndSuspend_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::InOrder);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::InOrder);
   m_scriptRunner->queueScriptForExecution(scriptLoader3, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
-    m_order.append(1);
+    m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
-    m_order.append(2);
+    m_order.push_back(2);
   }));
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
-    m_order.append(3);
+    m_order.push_back(3);
   }));
 
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(true));
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(false));
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
@@ skipping 19 matching lines @@
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader3, ScriptRunner::Async);
 
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
-    m_order.append(1);
+    m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
-    m_order.append(2);
+    m_order.push_back(2);
   }));
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
-    m_order.append(3);
+    m_order.push_back(3);
   }));
 
   m_platform.runSingleTask();
   m_scriptRunner->suspend();
   m_scriptRunner->resume();
   m_platform.runUntilIdle();
 
   // Make sure elements are correct.
   EXPECT_THAT(m_order, WhenSorted(ElementsAre(1, 2, 3)));
 }
 
 TEST_F(ScriptRunnerTest, LateNotifications) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::InOrder);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
-    m_order.append(1);
+    m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
-    m_order.append(2);
+    m_order.push_back(2);
   }));
 
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::InOrder);
   m_platform.runUntilIdle();
 
   // At this moment all tasks can be already executed. Make sure that we do not
   // crash here.
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::InOrder);
   m_platform.runUntilIdle();
 
@@ skipping 21 matching lines @@
 
   // m_scriptRunner is gone. We need to make sure that ScriptRunner::Task do not
   // access dead object.
   EXPECT_CALL(*scriptLoader1, execute()).Times(0);
   EXPECT_CALL(*scriptLoader2, execute()).Times(0);
 
   m_platform.runUntilIdle();
 }
 
 }  // namespace blink