third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp - Issue 2574773002: Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

Issue 2574773002: Migrate WTF::Vector::append() to ::push_back() [part 4 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

index d3dc33ec0b04a72aba8f186a6fc559f576e7f08a..e915e92425bdbd6d7a55322d29fd3f551491fef6 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp

@@ -66,7 +66,7 @@ void CustomElementUpgradeSorter::visit(HeapVector<Member<Element>>* result,

if (it == children.end())

return;

if (it->get()->isElementNode() && m_elements->contains(toElement(*it)))

- result->append(toElement(*it));

+ result->push_back(toElement(*it));

sorted(result, *it);

children.remove(it);

}