Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/notifications/message_center_settings_controller_unittest.cc

Issue 2574583005: Remove stl_util's deletion function use from message center notifier settings. (Closed)
Patch Set: nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | ui/message_center/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/message_center_settings_controller_unittest.cc
diff --git a/chrome/browser/notifications/message_center_settings_controller_unittest.cc b/chrome/browser/notifications/message_center_settings_controller_unittest.cc
index e3b05edefd4d845549e754245db267db5882e4fd..d33945abcc6bf933a6571c2153f5b74eb2f606b1 100644
--- a/chrome/browser/notifications/message_center_settings_controller_unittest.cc
+++ b/chrome/browser/notifications/message_center_settings_controller_unittest.cc
@@ -278,7 +278,7 @@ TEST_F(MessageCenterSettingsControllerTest, NotifierSortOrder) {
extension_service->AddExtension(baf_app.Build().get());
CreateController();
- std::vector<message_center::Notifier*> notifiers;
+ std::vector<std::unique_ptr<message_center::Notifier>> notifiers;
controller()->GetNotifierList(&notifiers);
#if !defined(OS_CHROMEOS)
@@ -292,8 +292,6 @@ TEST_F(MessageCenterSettingsControllerTest, NotifierSortOrder) {
EXPECT_EQ(kBarId, notifiers[0]->notifier_id.id);
EXPECT_EQ(kFooId, notifiers[1]->notifier_id.id);
-
- base::STLDeleteElements(&notifiers);
}
TEST_F(MessageCenterSettingsControllerTest, SetWebPageNotifierEnabled) {
« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | ui/message_center/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698