Make subresource filter activation agnostic of in-page navigations.

Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415
Committed: https://crrev.com/ca6bad482eae5bf092de9910ed4a0ef356e5ba1f
Cr-Commit-Position: refs/heads/master@{#438584}

[engedy, 2016-12-14 13:35:47]

Patchset #1 (id:1) has been deleted

[engedy, 2016-12-14 13:36:56]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 13:37:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2016-12-14 13:37:19]

engedy@chromium.org changed reviewers:
+ melandory@chromium.org

[engedy, 2016-12-14 13:37:19]

Tanja, could you please take a look?

[melandory, 2016-12-14 13:42:08]

On 2016/12/14 13:37:19, engedy wrote:
> Tanja, could you please take a look?

Looks awesome, thanks!

lgtm

[commit-bot: I haz the power, 2016-12-14 14:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 14:14:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[engedy, 2016-12-14 17:30:56]

Description was changed from

==========
Make subresource filter activation agnostic of in-page navigations.

BUG=637415
==========

to

==========
Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415
==========

[engedy, 2016-12-14 17:32:55]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:33:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2016-12-14 17:34:26]

Added one more test that we discussed offline.

[commit-bot: I haz the power, 2016-12-14 18:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:12:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[engedy, 2016-12-14 18:23:04]

The CQ bit was checked by engedy@chromium.org

[engedy, 2016-12-14 18:23:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
melandory@chromium.org
Link to the patchset: https://codereview.chromium.org/2574193002/#ps80001
(title: "Final test fix.")

[commit-bot: I haz the power, 2016-12-14 18:24:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:23:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481739784927660,
"parent_rev": "feecd0e8395565226eff46d298155bd777174732", "commit_rev":
"132ce258133f6085f313b8f68fc0cd44514a988d"}

[commit-bot: I haz the power, 2016-12-14 19:24:00]

Description was changed from

==========
Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415
==========

to

==========
Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415

Review-Url: https://codereview.chromium.org/2574193002
==========

[commit-bot: I haz the power, 2016-12-14 19:24:01]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-14 19:28:19]

Description was changed from

==========
Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415

Review-Url: https://codereview.chromium.org/2574193002
==========

to

==========
Make subresource filter activation agnostic of in-page navigations.

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415

Committed: https://crrev.com/ca6bad482eae5bf092de9910ed4a0ef356e5ba1f
Cr-Commit-Position: refs/heads/master@{#438584}
==========

[commit-bot: I haz the power, 2016-12-14 19:28:20]

Patchset 4 (id:??) landed as
https://crrev.com/ca6bad482eae5bf092de9910ed4a0ef356e5ba1f
Cr-Commit-Position: refs/heads/master@{#438584}