Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2573093002: Simplify unit tests for SubresourceFilterAgent. (Closed)

Created:
4 years ago by engedy
Modified:
4 years ago
Reviewers:
melandory
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify unit tests for SubresourceFilterAgent. The agent used to have separate unittests that verified that the right values were recorded into histograms. To reduce duplication, this CL merges these tests into the corresponding tests that verify basic functionality. BUG=637415 Committed: https://crrev.com/003b57dcccd8406ff1145dc2aee136c3c994b200 Cr-Commit-Position: refs/heads/master@{#438501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -143 lines) Patch
M components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc View 5 chunks +103 lines, -143 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
engedy
Piece of mechanical refactoring. Tanja, could you please take a quick look?
4 years ago (2016-12-14 12:56:44 UTC) #3
melandory
On 2016/12/14 12:56:44, engedy wrote: > Piece of mechanical refactoring. Tanja, could you please take ...
4 years ago (2016-12-14 12:57:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573093002/1
4 years ago (2016-12-14 12:58:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 13:31:12 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-14 13:33:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/003b57dcccd8406ff1145dc2aee136c3c994b200
Cr-Commit-Position: refs/heads/master@{#438501}

Powered by Google App Engine
This is Rietveld 408576698