components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2574193002: Make subresource filter activation agnostic of in-page navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2574193002: Make subresource filter activation agnostic of in-page navigations. (Closed)

Patch Set: Final test fix. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index c2b24107f6b5516a07423924ba9879c9a65c77d4..f25cae30c19cb6915d74d7a285f85f545e2e5e20 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -311,7 +311,7 @@ class ContentSubresourceFilterDriverFactoryTest

EXPECT_CALL(*driver(), ActivateForProvisionalLoad(

::testing::_, ::testing::_, ::testing::_))

.Times(0);

- EXPECT_CALL(*client(), ToggleNotificationVisibility(::testing::_)).Times(1);

+ EXPECT_CALL(*client(), ToggleNotificationVisibility(::testing::_)).Times(0);

content::RenderFrameHostTester::For(main_rfh())

->SimulateNavigationCommit(GURL(kExampleUrl));

::testing::Mock::VerifyAndClearExpectations(driver());