Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2573943002: WebUI: Vulcanize MD Settings at compile time. (Closed)

Created:
4 years ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Nico, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69 Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451417} Committed: https://chromium.googlesource.com/chromium/src/+/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e

Patch Set 1 #

Patch Set 2 : comment out uglify #

Patch Set 3 : Fix #

Patch Set 4 : Fix CrOS compilation. #

Patch Set 5 : normpath #

Patch Set 6 : Change parent #

Patch Set 7 : Undo #

Patch Set 8 : Should work #

Patch Set 9 : Rename cr:settings icon to cr:settings_icon to fix global settings object. #

Total comments: 2

Patch Set 10 : Fix path to crisper.js to not be relative. #

Total comments: 2

Patch Set 11 : Nits. #

Patch Set 12 : Rebased. #

Patch Set 13 : remove flattenhtml true from vulcanized.html and crisper.js, not needed. #

Patch Set 14 : Undo flattenhtml removal, I was wrong. #

Patch Set 15 : Rebase #

Patch Set 16 : Rebase #

Patch Set 17 : Nit #

Total comments: 8

Patch Set 18 : Resolving conflicts, addressing comments. #

Patch Set 19 : Adding gzip for vulcanized.html and crisper.js #

Patch Set 20 : Rebasing #

Patch Set 21 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -6 lines) Patch
M chrome/browser/resources/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +12 lines, -1 line 0 comments Download
A chrome/browser/resources/settings/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/settings_resources_vulcanized.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +7 lines, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/icons.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 86 (67 generated)
Dan Beam
i know this isn't ready for review, but just had some comments that might help ...
3 years, 10 months ago (2017-01-30 21:41:46 UTC) #25
dpapad
Please review: thakis --> tools/gritsettings/resource_ids dbeam --> everything else https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/html/i18n_template.html File ui/webui/resources/html/i18n_template.html (right): https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/html/i18n_template.html#newcode1 ui/webui/resources/html/i18n_template.html:1: ...
3 years, 10 months ago (2017-02-10 22:53:38 UTC) #36
Dan Beam
very excite! https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resources/settings/about_page/about_page.html#newcode97 chrome/browser/resources/settings/about_page/about_page.html:97: obsoleteSystemInfo_, currentUpdateStatusEvent_)]]" can you add a comment ...
3 years, 10 months ago (2017-02-10 23:14:48 UTC) #37
Nico
resource_ids lgtm
3 years, 10 months ago (2017-02-13 17:38:11 UTC) #40
dpapad
https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resources/settings/about_page/about_page.html#newcode97 chrome/browser/resources/settings/about_page/about_page.html:97: obsoleteSystemInfo_, currentUpdateStatusEvent_)]]" On 2017/02/10 at 23:14:47, Dan Beam wrote: ...
3 years, 10 months ago (2017-02-13 18:53:54 UTC) #41
Dan Beam
most excellent lgtm
3 years, 10 months ago (2017-02-13 19:56:54 UTC) #42
dpapad
On 2017/02/13 at 19:56:54, dbeam wrote: > most excellent lgtm Thanks. Per our offline discussion, ...
3 years, 10 months ago (2017-02-14 00:49:57 UTC) #43
Dan Beam
still lgtm
3 years, 10 months ago (2017-02-14 01:05:05 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573943002/420001
3 years, 10 months ago (2017-02-14 01:09:21 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/364070)
3 years, 10 months ago (2017-02-14 05:11:42 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573943002/420001
3 years, 10 months ago (2017-02-14 06:14:46 UTC) #51
commit-bot: I haz the power
Committed patchset #19 (id:420001) as https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69
3 years, 10 months ago (2017-02-14 07:07:04 UTC) #54
tyoshino (SeeGerritForStatus)
A revert of this CL (patchset #19 id:420001) has been created in https://codereview.chromium.org/2693113002/ by tyoshino@chromium.org. ...
3 years, 10 months ago (2017-02-14 09:40:11 UTC) #55
dpapad
On 2017/02/14 at 09:40:11, tyoshino wrote: > A revert of this CL (patchset #19 id:420001) ...
3 years, 10 months ago (2017-02-16 01:08:15 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573943002/440001
3 years, 10 months ago (2017-02-17 09:44:44 UTC) #71
commit-bot: I haz the power
Committed patchset #20 (id:440001) as https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de
3 years, 10 months ago (2017-02-17 10:20:18 UTC) #74
mikecase (-- gone --)
A revert of this CL (patchset #20 id:440001) has been created in https://codereview.chromium.org/2700983003/ by mikecase@chromium.org. ...
3 years, 10 months ago (2017-02-17 17:41:41 UTC) #75
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573943002/460001
3 years, 10 months ago (2017-02-18 02:35:26 UTC) #83
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 04:14:15 UTC) #86
Message was sent while issue was closed.
Committed patchset #21 (id:460001) as
https://chromium.googlesource.com/chromium/src/+/2d84fd7e2cdb13ae3fbe894319ef...

Powered by Google App Engine
This is Rietveld 408576698