|
|
Created:
4 years ago by dpapad Modified:
3 years, 10 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, stevenjb Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebUI: Vulcanize MD Settings at compile time.
BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2573943002
Cr-Original-Original-Commit-Position: refs/heads/master@{#450285}
Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69
Review-Url: https://codereview.chromium.org/2573943002
Cr-Original-Commit-Position: refs/heads/master@{#451275}
Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de
Review-Url: https://codereview.chromium.org/2573943002
Cr-Commit-Position: refs/heads/master@{#451417}
Committed: https://chromium.googlesource.com/chromium/src/+/2d84fd7e2cdb13ae3fbe894319ef828febd14f0e
Patch Set 1 #Patch Set 2 : comment out uglify #Patch Set 3 : Fix #Patch Set 4 : Fix CrOS compilation. #Patch Set 5 : normpath #Patch Set 6 : Change parent #Patch Set 7 : Undo #Patch Set 8 : Should work #Patch Set 9 : Rename cr:settings icon to cr:settings_icon to fix global settings object. #
Total comments: 2
Patch Set 10 : Fix path to crisper.js to not be relative. #
Total comments: 2
Patch Set 11 : Nits. #Patch Set 12 : Rebased. #Patch Set 13 : remove flattenhtml true from vulcanized.html and crisper.js, not needed. #Patch Set 14 : Undo flattenhtml removal, I was wrong. #Patch Set 15 : Rebase #Patch Set 16 : Rebase #Patch Set 17 : Nit #
Total comments: 8
Patch Set 18 : Resolving conflicts, addressing comments. #Patch Set 19 : Adding gzip for vulcanized.html and crisper.js #Patch Set 20 : Rebasing #Patch Set 21 : Rebase #Messages
Total messages: 86 (67 generated)
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG= ========== to ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time using GN. Lot of this work is based on michaelpg's https://codereview.chromium.org/2513673005/. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #6 (id:100001) has been deleted
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #7 (id:140001) has been deleted
Patchset #7 (id:160001) has been deleted
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. Lot of this work is based on michaelpg's https://codereview.chromium.org/2513673005/. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time using GN. Lot of this work is based on michaelpg's https://codereview.chromium.org/2513673005/. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
i know this isn't ready for review, but just had some comments that might help https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/htm... File ui/webui/resources/html/i18n_template.html (right): https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/htm... ui/webui/resources/html/i18n_template.html:1: <script src="chrome://resources/js/i18n_template_no_process.js"></script> wait, is this required because the <include> in i18n_template_no_process.js no longer works? https://cs.chromium.org/chromium/src/ui/webui/resources/js/i18n_template.js?q... https://codereview.chromium.org/2573943002/diff/240001/chrome/browser/resourc... File chrome/browser/resources/vulcanize_gn.py (right): https://codereview.chromium.org/2573943002/diff/240001/chrome/browser/resourc... chrome/browser/resources/vulcanize_gn.py:160: '<include src="', '<include src-disabled="')) tmp.write(output .replace('<include src="', '<include src-disabled="') .replace('<head>', '<head><base href="chrome://%s">' % host)) might also help ;)
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. Lot of this work is based on michaelpg's https://codereview.chromium.org/2513673005/. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time using GN. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + dbeam@chromium.org, thakis@chromium.org
Please review: thakis --> tools/gritsettings/resource_ids dbeam --> everything else https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/htm... File ui/webui/resources/html/i18n_template.html (right): https://codereview.chromium.org/2573943002/diff/220001/ui/webui/resources/htm... ui/webui/resources/html/i18n_template.html:1: <script src="chrome://resources/js/i18n_template_no_process.js"></script> On 2017/01/30 at 21:41:46, Dan Beam wrote: > wait, is this required because the <include> in i18n_template_no_process.js no longer works? > > https://cs.chromium.org/chromium/src/ui/webui/resources/js/i18n_template.js?q... Correct. https://codereview.chromium.org/2573943002/diff/240001/chrome/browser/resourc... File chrome/browser/resources/vulcanize_gn.py (right): https://codereview.chromium.org/2573943002/diff/240001/chrome/browser/resourc... chrome/browser/resources/vulcanize_gn.py:160: '<include src="', '<include src-disabled="')) On 2017/01/30 at 21:41:46, Dan Beam wrote: > tmp.write(output > .replace('<include src="', '<include src-disabled="') > .replace('<head>', '<head><base href="chrome://%s">' % host)) > > might also help ;) Already done in previous CLs (that have landed now).
very excite! https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... chrome/browser/resources/settings/about_page/about_page.html:97: obsoleteSystemInfo_, currentUpdateStatusEvent_)]]" can you add a comment about this? https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... File chrome/browser/resources/vulcanize_gn.py (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... chrome/browser/resources/vulcanize_gn.py:159: os.path.join(out_path, _REQUEST_LIST_FILE)), are you going to rebase on calamity@'s "vulcanize history with GN" patch? https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/cr_... File ui/webui/resources/cr_elements/icons.html (right): https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/cr_... ui/webui/resources/cr_elements/icons.html:39: <g id="search"><path d="M15.5 14h-.79l-.28-.27C15.41 12.59 16 11.11 16 9.5 16 5.91 13.09 3 9.5 3S3 5.91 3 9.5 5.91 16 9.5 16c1.61 0 3.09-.59 4.23-1.57l.27.28v.79l5 4.99L20.49 19l-4.99-5zm-6 0C7.01 14 5 11.99 5 9.5S7.01 5 9.5 5 14 7.01 14 9.5 11.99 14 9.5 14z"></path></g> can you add a comment? https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/htm... File ui/webui/resources/html/i18n_template.html (right): https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/htm... ui/webui/resources/html/i18n_template.html:1: <script src="chrome://resources/js/i18n_template_no_process.js"></script> why did we need this again? does this double-process? i thought we were going to split these files into i18n_template_no_process.js i18n_template_process.js and include them both here, and then make a i18n_template.js that just did <include src="i18n_template_no_process.js"> <include src="i18n_template_process.js"> for those still using GRIT
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
resource_ids lgtm
https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... chrome/browser/resources/settings/about_page/about_page.html:97: obsoleteSystemInfo_, currentUpdateStatusEvent_)]]" On 2017/02/10 at 23:14:47, Dan Beam wrote: > can you add a comment about this? Done. https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... File chrome/browser/resources/vulcanize_gn.py (right): https://codereview.chromium.org/2573943002/diff/380001/chrome/browser/resourc... chrome/browser/resources/vulcanize_gn.py:159: os.path.join(out_path, _REQUEST_LIST_FILE)), On 2017/02/10 at 23:14:47, Dan Beam wrote: > are you going to rebase on calamity@'s "vulcanize history with GN" patch? Rebased. https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/cr_... File ui/webui/resources/cr_elements/icons.html (right): https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/cr_... ui/webui/resources/cr_elements/icons.html:39: <g id="search"><path d="M15.5 14h-.79l-.28-.27C15.41 12.59 16 11.11 16 9.5 16 5.91 13.09 3 9.5 3S3 5.91 3 9.5 5.91 16 9.5 16c1.61 0 3.09-.59 4.23-1.57l.27.28v.79l5 4.99L20.49 19l-4.99-5zm-6 0C7.01 14 5 11.99 5 9.5S7.01 5 9.5 5 14 7.01 14 9.5 11.99 14 9.5 14z"></path></g> On 2017/02/10 at 23:14:48, Dan Beam wrote: > can you add a comment? Done. https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/htm... File ui/webui/resources/html/i18n_template.html (right): https://codereview.chromium.org/2573943002/diff/380001/ui/webui/resources/htm... ui/webui/resources/html/i18n_template.html:1: <script src="chrome://resources/js/i18n_template_no_process.js"></script> On 2017/02/10 at 23:14:48, Dan Beam wrote: > why did we need this again? does this double-process? Removing this causes the following error Uncaught ReferenceError: i18nTemplate is not defined at crisper.js:593 So it is not about avoiding double-process, it's about including this file. In vulcanized mode this is not included otherwise because the following line is ignored https://cs.chromium.org/chromium/src/ui/webui/resources/js/i18n_template.js?q... i thought we were going to split these files into > > i18n_template_no_process.js > i18n_template_process.js > > and include them both here, and then make a > > i18n_template.js > > that just did > > <include src="i18n_template_no_process.js"> > <include src="i18n_template_process.js"> > > for those still using GRIT Rebased after yours https://codereview.chromium.org/2691693003.
most excellent lgtm
On 2017/02/13 at 19:56:54, dbeam wrote: > most excellent lgtm Thanks. Per our offline discussion, I made it so that vulcanized.html and crisper.js are gzipped. PTAL.
still lgtm
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2573943002/#ps420001 (title: "Adding gzip for vulcanized.html and crisper.js")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 420001, "attempt_start_ts": 1487052868746960, "parent_rev": "5d93c725a9fd0f77f74e8eb7544ccc386b72e96a", "commit_rev": "e45268fb9d6c1c9c5a57617f6d16e4795c349d69"}
Message was sent while issue was closed.
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... ==========
Message was sent while issue was closed.
Committed patchset #19 (id:420001) as https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16...
Message was sent while issue was closed.
A revert of this CL (patchset #19 id:420001) has been created in https://codereview.chromium.org/2693113002/ by tyoshino@chromium.org. The reason for reverting is: See http://crbug.com/691965 It looks this caused flakiness..
Message was sent while issue was closed.
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... ==========
On 2017/02/14 at 09:40:11, tyoshino wrote: > A revert of this CL (patchset #19 id:420001) has been created in https://codereview.chromium.org/2693113002/ by tyoshino@chromium.org. > > The reason for reverting is: See http://crbug.com/691965 It looks this caused flakiness.. I am re-opening this CL. I plan to reland it after https://codereview.chromium.org/2654723002 lands, which should address the problem.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2573943002/#ps440001 (title: "Rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 440001, "attempt_start_ts": 1487324667165270, "parent_rev": "da1a75010d17285002bab1fda9ca510119c69814", "commit_rev": "29db19d0c973a8990283ec4b81111db5bdb8d2de"}
Message was sent while issue was closed.
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111... ==========
Message was sent while issue was closed.
Committed patchset #20 (id:440001) as https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111...
Message was sent while issue was closed.
A revert of this CL (patchset #20 id:440001) has been created in https://codereview.chromium.org/2700983003/ by mikecase@chromium.org. The reason for reverting is: Causing compilation failures on Android Perf bots. See crbug/693619.
Message was sent while issue was closed.
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111... ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111... ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2573943002/#ps460001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 460001, "attempt_start_ts": 1487385295319320, "parent_rev": "5ac15460e9aab7b68f858f911b2e4ced8e0aadaa", "commit_rev": "2d84fd7e2cdb13ae3fbe894319ef828febd14f0e"}
Message was sent while issue was closed.
Description was changed from ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111... ========== to ========== WebUI: Vulcanize MD Settings at compile time. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Original-Commit-Position: refs/heads/master@{#450285} Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16... Review-Url: https://codereview.chromium.org/2573943002 Cr-Original-Commit-Position: refs/heads/master@{#451275} Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b8111... Review-Url: https://codereview.chromium.org/2573943002 Cr-Commit-Position: refs/heads/master@{#451417} Committed: https://chromium.googlesource.com/chromium/src/+/2d84fd7e2cdb13ae3fbe894319ef... ==========
Message was sent while issue was closed.
Committed patchset #21 (id:460001) as https://chromium.googlesource.com/chromium/src/+/2d84fd7e2cdb13ae3fbe894319ef... |