WebUI: disable optimizations (vulcanize) in debug builds

WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG=673825, 691965
Review-Url: https://codereview.chromium.org/2654723002
Cr-Commit-Position: refs/heads/master@{#451240}
Committed: https://chromium.googlesource.com/chromium/src/+/6bd4c19f45d6e2bba69f9668516a829f39ca9a1f

[Dan Beam, 2017-01-24 01:50:55]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-01-24 01:51:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 01:52:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 03:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:03:21]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-02-14 20:47:13]

Description was changed from

==========
WebUI: turn off vulcanize for debug builds

R=
BUG=673825
==========

to

==========
WebUI: turn off vulcanize for debug builds

R=brettw@chromium.org
BUG=673825
==========

[Dan Beam, 2017-02-14 20:47:13]

dbeam@chromium.org changed reviewers:
+ brettw@chromium.org

[Dan Beam, 2017-02-14 20:48:28]

Description was changed from

==========
WebUI: turn off vulcanize for debug builds

R=brettw@chromium.org
BUG=673825
==========

to

==========
WebUI: disable optimizations (vulcanize) in debug builds

R=brettw@chromium.org
BUG=673825
==========

[Dan Beam, 2017-02-14 20:48:41]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 20:49:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-14 20:50:10]

On 2017/02/14 at 20:48:36, dbeam wrote:
> 

LGTM. Perhaps add a comment in the CL description, that optimizations make the
prod code faster, but the tests slower (because they load the entire JS/HTML
bundle for each unit test).

[Dan Beam, 2017-02-14 20:54:28]

Description was changed from

==========
WebUI: disable optimizations (vulcanize) in debug builds

R=brettw@chromium.org
BUG=673825
==========

to

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=brettw@chromium.org
BUG=673825
==========

[commit-bot: I haz the power, 2017-02-14 22:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:07:15]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-15 18:12:24]

On 2017/02/14 at 20:50:10, dpapad wrote:
> On 2017/02/14 at 20:48:36, dbeam wrote:
> > 
> 
> LGTM. Perhaps add a comment in the CL description, that optimizations make the
prod code faster, but the tests slower (because they load the entire JS/HTML
bundle for each unit test).

Also, maybe link this CL to issue 691965 too.

[Dan Beam, 2017-02-16 02:44:11]

ping brettw@

[Dan Beam, 2017-02-16 02:44:32]

Description was changed from

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=brettw@chromium.org
BUG=673825
==========

to

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=brettw@chromium.org
BUG=673825,691965
==========

[dpapad, 2017-02-16 17:45:05]

dpapad@chromium.org changed reviewers:
+ dpapad@chromium.org

[sky, 2017-02-17 00:10:05]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-02-17 00:10:05]

LGTM - but please add a comment as to why the flag is based on build type.

[Dan Beam, 2017-02-17 00:42:40]

Description was changed from

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=brettw@chromium.org
BUG=673825,691965
==========

to

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG=673825,691965
==========

[Dan Beam, 2017-02-17 00:42:40]

dbeam@chromium.org changed reviewers:
- brettw@chromium.org

[Dan Beam, 2017-02-17 00:42:52]

On 2017/02/17 00:10:05, sky wrote:
> LGTM - but please add a comment as to why the flag is based on build type.

Done.

[Dan Beam, 2017-02-17 00:42:58]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-02-17 00:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2654723002/#ps40001
(title: "add comment")

[commit-bot: I haz the power, 2017-02-17 00:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:47:51]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Dan Beam, 2017-02-17 02:57:58]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:58:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 06:15:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487300278371590,
"parent_rev": "7234ea5d5045f6fedbc01503613cc26a2e264670", "commit_rev":
"6bd4c19f45d6e2bba69f9668516a829f39ca9a1f"}

[commit-bot: I haz the power, 2017-02-17 06:16:06]

Description was changed from

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG=673825,691965
==========

to

==========
WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG=673825,691965

Review-Url: https://codereview.chromium.org/2654723002
Cr-Commit-Position: refs/heads/master@{#451240}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bd4c19f45d6e2bba69f9668516a...
==========

[commit-bot: I haz the power, 2017-02-17 06:16:07]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6bd4c19f45d6e2bba69f9668516a...