ui/webui/resources/html/i18n_template.html - Issue 2573943002: WebUI: Vulcanize MD Settings at compile time.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/html/i18n_template.html

Issue 2573943002: WebUI: Vulcanize MD Settings at compile time. (Closed)

Patch Set: Nit Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 <script src="chrome://resources/js/i18n_template_no_process.js"></script>
	Dan Beam 2017/02/10 23:14:48 why did we need this again? does this double-proce why did we need this again? does this double-process? i thought we were going to split these files into i18n_template_no_process.js i18n_template_process.js and include them both here, and then make a i18n_template.js that just did <include src="i18n_template_no_process.js"> <include src="i18n_template_process.js"> for those still using GRIT dpapad 2017/02/13 18:53:54 Removing this causes the following error Uncaught Show quoted text On 2017/02/10 at 23:14:48, Dan Beam wrote: > why did we need this again? does this double-process? Removing this causes the following error Uncaught ReferenceError: i18nTemplate is not defined at crisper.js:593 So it is not about avoiding double-process, it's about including this file. In vulcanized mode this is not included otherwise because the following line is ignored https://cs.chromium.org/chromium/src/ui/webui/resources/js/i18n_template.js?q... i thought we were going to split these files into Show quoted text > > i18n_template_no_process.js > i18n_template_process.js > > and include them both here, and then make a > > i18n_template.js > > that just did > > <include src="i18n_template_no_process.js"> > <include src="i18n_template_process.js"> > > for those still using GRIT Rebased after yours https://codereview.chromium.org/2691693003.
1 <script src="chrome://resources/js/i18n_template.js"></script>	2 <script src="chrome://resources/js/i18n_template.js"></script>

OLD	NEW

« ui/webui/resources/cr_elements/icons.html ('K') | « ui/webui/resources/cr_elements/icons.html ('k') | no next file » | no next file with comments »