Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2573823002:
Fix IME tray bubble (and other tray bubble views). (Closed)
|
Created:
4 years ago by Evan Stade Modified:
4 years ago Reviewers:
msw CC:
chromium-reviews Target Ref:
refs/pending/branch-heads/2883 Project:
chromium Visibility:
Public. |
DescriptionFix IME tray bubble (and other tray bubble views).
This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting
a background for bubble contents views.
The symptom I observed is a black background (due to the layer being
opaque and painting nothing). This should also fix the subpixel text
corruption shown in the bug.
BUG=660510
TBR=msw@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2485793002
Cr-Commit-Position: refs/heads/master@{#430500}
(cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458)
Review-Url: https://codereview.chromium.org/2573823002
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=663192 Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ========== to ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ==========
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ========== to ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ==========
estade@chromium.org changed reviewers: + msw@chromium.org
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ========== to ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ==========
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481647584671070, "parent_rev":
"9e236213c731c423907b8eb46e179ef61b75a0ec", "commit_rev":
"7316b926f4d4b12d2d9bbf72b2a57a921f1a9b1c"}
Message was sent while issue was closed.
Description was changed from ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) ========== to ========== Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) Review-Url: https://codereview.chromium.org/2573823002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
