Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: ui/views/bubble/bubble_dialog_delegate.cc

Issue 2573823002: Fix IME tray bubble (and other tray bubble views). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_dialog_delegate.cc
diff --git a/ui/views/bubble/bubble_dialog_delegate.cc b/ui/views/bubble/bubble_dialog_delegate.cc
index 5251a7ede56d99545828dd488e405d8cf46bafdf..7799431151486abaf6ebd9c19bc657af3c31f411 100644
--- a/ui/views/bubble/bubble_dialog_delegate.cc
+++ b/ui/views/bubble/bubble_dialog_delegate.cc
@@ -298,6 +298,12 @@ void BubbleDialogDelegateView::UpdateColorsFromTheme(
BubbleFrameView* frame_view = GetBubbleFrameView();
if (frame_view)
frame_view->bubble_border()->set_background_color(color());
+
+ // When there's an opaque layer, the bubble border background won't show
+ // through, so explicitly paint a background color.
+ set_background(layer() && layer()->fills_bounds_opaquely()
+ ? Background::CreateSolidBackground(color())
+ : nullptr);
}
void BubbleDialogDelegateView::HandleVisibilityChanged(Widget* widget,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698